-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_tracking lacks sub-second data precision on time #42
Comments
On a very busy server it turns out that we were getting duplicate |
I'd just use DateTime64(6) as a DateTime64 takes 8 bytes regardless of specificity. You can go up to 9 decimal places for seconds, but the tracking logs themselves only go to microseconds. |
Some more info. You will need to also update the Vector Clickhouse sink with...
As of Vector 0.34 it will support encoding.timestamp_format "unix_us" which should also work without requiring See also vectordotdev/vector#5797 |
Hey Bryan, sorry for the late response. There was a maintainership change in progress. I've looked into the issue you mentioned and the PR you created (thank you so much for that, by the way). I can see how making this change would allow for finer granular control over the analytics. However, we are also concerned about the performance impact it might have on existing users. I noticed that you mentioned you tried this out on a server with 1.2B rows. I would be very interested to know if you have any time metrics for that upgrade process. |
Hi @Danyal-Faheem No problem and sorry for my own delay! I do have some notes on that upgrade process and will try to get those to you in the next day or two. |
Problem:
data analytics teams may need to differentiate between events at the sub-second level but _tracking uses a simple DateTime field.
Suggestion:
Consider using at least a DateTime64(3) for milliseconds, as the tracking logs themselves have microsecond specificity.
then same thing for the
events
tableI believe the Vector parse_timestamp function as written should include the milliseconds from tracking log entries, so they should be available.
The text was updated successfully, but these errors were encountered: