Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox 69 incompatibility, easy to solve by two additional settings #285

Open
dmilith opened this issue Sep 4, 2019 · 12 comments
Open

Comments

@dmilith
Copy link

dmilith commented Sep 4, 2019

ShadowFox could set these values under about:config automatically:

  1. toolkit.legacyUserProfileCustomizations.stylesheets => true
  2. browser.in-content.dark-mode => true

Without these two ShadowFox will have no effect in Firefox 69+

@dmilith dmilith changed the title Firefox 69 Firefox 69 incompatibility, easy to solve by two additional settings Sep 4, 2019
@ShalokShalom
Copy link
Contributor

Where can I kiss you? This saved my day. Could someone implement this?

@rpgdev
Copy link

rpgdev commented Oct 1, 2019

2. `browser.in-content.dark-mode` => true

I'm on firefox 69 and don't seem to need this set to true.

@gen3vra
Copy link

gen3vra commented Oct 13, 2019

Came here and found this after it wouldn't work for me. This fixed it, thank you.

@RenatoLopes771
Copy link

One of the devs should pin this on the homepage as a temporary workaround

@sanyer
Copy link

sanyer commented Oct 18, 2019

There is a note about this in wiki, but not on repo's README.md.

@akitakedits
Copy link

Many thanks ♥

@ShalokShalom
Copy link
Contributor

Why is this not possible to incorporate in the code?

@akitakedits
Copy link

It should be, but seems like the project hasn't been updated in forever, can consider it dead.

@ShalokShalom
Copy link
Contributor

I see commits?

@overdodactyl
Copy link
Owner

This change would have to be implemented in the updater repo. See this issue here:

arguablykomodo/shadowfox-updater#53

@toxicbubble
Copy link

toxicbubble commented May 11, 2020

Can the info that exists on https://github.com/overdodactyl/ShadowFox/wiki/Installation and an additional line for browser.in-content.dark-mode => true be set be added to the "Installation and Updating" section of README.md at least? I spent ages trying to get it to work, and nothing in the installation section of the README.md mentions this. right now it's very unclear why after installation nothing changes.

Thynix added a commit to Thynix/ShadowFox that referenced this issue May 24, 2021
Modern Firefox requires it to be set for ShadowFox to load. See
[this issue](overdodactyl#285 (comment)).
@Thynix
Copy link

Thynix commented May 24, 2021

@toxicbubble Good idea - I just made a fork and did that. I'll look into getting the updater to automatically do it later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants