Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bun remove non-existent-package doesn't throw any error #14870

Open
vijaybritto opened this issue Oct 28, 2024 · 1 comment · May be fixed by #14882
Open

bun remove non-existent-package doesn't throw any error #14870

vijaybritto opened this issue Oct 28, 2024 · 1 comment · May be fixed by #14882
Assignees
@nektro
Labels
bug Something isn't working bun install Something that relates to the npm-compatible client

Comments

@vijaybritto
Copy link

What version of Bun is running?

1.1.29+6d43b3662

What platform is your computer?

Darwin 22.6.0 arm64 arm

What steps can reproduce the bug?

Run bun remove any-invalid-package in any workspace to see that it says done without mentioning that the package is not found in package.json.

This suppresses typo errors in the package names and we dont realize that we didnt remove the package.

What is the expected behavior?

It should throw an error similar to yarn or other package managers. For ex, in yarn v1 we get this:
Image

What do you see instead?

Image
No errors

Additional information

No response
@vijaybritto vijaybritto added bug Something isn't working needs triage labels Oct 28, 2024
@nektro nektro added bun install Something that relates to the npm-compatible client and removed needs triage labels Oct 28, 2024
@nektro nektro self-assigned this Oct 28, 2024
@nektro nektro linked a pull request Oct 28, 2024 that will close this issue
Draft
@kaioduarte
Copy link
Contributor

It used to behave like that but it was changed a while ago (see #8032) to be closer to what npm does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nektro nektro

Labels
bug Something isn't working bun install Something that relates to the npm-compatible client
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pm: error when removing package that does not exist oven-sh/bun
3 participants
@vijaybritto @nektro @kaioduarte