Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bun still ask for Github credential when SSH key is set up #12172

Open
Paper-Folding opened this issue Jun 26, 2024 · 0 comments
Open

Bun still ask for Github credential when SSH key is set up #12172

Paper-Folding opened this issue Jun 26, 2024 · 0 comments
Assignees
Labels
bug Something isn't working npm Something that relates to the npm-compatible client

Comments

@Paper-Folding
Copy link

Paper-Folding commented Jun 26, 2024

What version of Bun is running?

1.1.17

What platform is your computer?

Windows

What steps can reproduce the bug?

  1. Add ssh+git as a dependency, for example:
"my-lib": "git+ssh://[email protected]/My-Namespace/my-lib.git#1.0.0"
  1. Note that SSH key has been generated and add to git locally, i.e., these command is being executed before:
git config --global gpg.format ssh
git config --global user.signingkey "C:\Users\[my-username]\.ssh\id_ed25519.pub"
  1. Run bun install
  2. A "Connect to Github" dialog will appear first:
    image
  3. Close the dialog manually and "The string binding is invalid" error dialog will show:
    image
  4. Close the error dialog again and I'm using vscode, vscode will ask me for password, so I skip with esc key
  5. Finally, bun will install the dependency successfully via SSH key.

The problem is, the dialog in step 5 and 6 should not appear. When I'm using yarn before, this issue does not exists.

What is the expected behavior?

The dialog in step 5 and 6 above should not appear, Bun should check for SSH key first before asking for github credential.

What do you see instead?

No response

Additional information

No response

@Paper-Folding Paper-Folding added bug Something isn't working needs triage labels Jun 26, 2024
@Paper-Folding Paper-Folding changed the title Bug still ask for Github credential when SSH key is set up Bun still ask for Github credential when SSH key is set up Jun 26, 2024
@Jarred-Sumner Jarred-Sumner added the npm Something that relates to the npm-compatible client label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working npm Something that relates to the npm-compatible client
Projects
None yet
Development

No branches or pull requests

3 participants