Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading name/value for "contact" #79

Open
sdalu opened this issue Jun 11, 2022 · 1 comment
Open

Misleading name/value for "contact" #79

sdalu opened this issue Jun 11, 2022 · 1 comment

Comments

@sdalu
Copy link

sdalu commented Jun 11, 2022

A value of 1 for "contact" means the contact is "open".
But when we read "contact == 1" we tend to naturally interpret it as "there is a contact" (so it is closed)

@otaviojr
Copy link
Owner

otaviojr commented Jun 12, 2022

Hi @sdalu,

in the latest version, I created an option in the open-close configuring dialog.

Use "closed" as active state.

You can use it to change this behavior.

I didn't change the default behavior because this code is available for some years now and I didn't want to break someone's else flows.

And that is really trick... in my case, I want to know if my door is open. So makes sense for my use case that "1" means doors open.

I think that having this option will allow to have more meaning in both cases.

Regards,
Otávio Ribeiro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants