Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialize Unexploded Query Parameters #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChaelCodes
Copy link

Description

OpenAPI supports multiple methods of parameter deserialization. Documentation here: https://swagger.io/docs/specification/serialization/ In order to parse these comma-separated, pipe-delimited, and space-delimited arrays, we need to deserialize them according to the rules defined in the Parameter before checking them against the schema.

closes #122

This is a rough draft of a way that we could handle this to open the conversation. Let me know if you want anything changed, extracted, or additional test cases in a different location.

OpenAPI supports multiple methods of parameter deserialization.
Documentation here: https://swagger.io/docs/specification/serialization/
In order to parse these comma-separated, pipe-delimited, and space-delimited arrays,
we need to deserialize them according to the rules defined in the Parameter before
checking them against the schema.
@mattmanning
Copy link

👍

@ahx
Copy link

ahx commented May 21, 2023

Hi. Super cool that you are taking on fixing this problem in this library! I have build https://github.com/ahx/openapi_parameters which should be able to deserialize all variants of explode and style. It's used in another gem, but I think that it would be cool if openapi_parser would be capable to parse parameters as specified. So, since you are interested in this topic as well, maybe you want to take a look at openapi_parameters and see if it can be used here? I did not find the time to look into that so far.
If that is not an option right now, I would love this PR to be merged. (👍🏼)

@dpashkevich
Copy link

@ota42y any feedback on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support array in query parameter
4 participants