Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block area for accidental touch #348

Closed
DeltaFlyerW opened this issue Apr 24, 2024 · 5 comments · May be fixed by #350
Closed

Add block area for accidental touch #348

DeltaFlyerW opened this issue Apr 24, 2024 · 5 comments · May be fixed by #350

Comments

@DeltaFlyerW
Copy link
Contributor

Description

Add an anti-accidental touch feature, which allow user to select some area on screen that the touch inside will not be a valid input event for game.

Justification

As screen-to-body ratio grows in decent mobile devices, accidental touch has been a problem for many play styles. During play, accidental touch causes unexpected drop as your palm or finger touch screen edge.

Possible Implement

Add a option under Options/Advance which pop a page when click. In the page, user can add new block area or drag the zero width area from the screen edge.

Alternative methods

A workground is to create float window in edge with third party application. But it would be a good idea to integrate this feature into osu-doid.
@DeltaFlyerW
Copy link
Contributor Author

A possible implementation for setting page is creating a Preference subclass. It will start a webview and receive json config by WebAppInterface. Below is a example page.
Sample Setting Page

@Reco1I
Copy link
Contributor

Reco1I commented Apr 24, 2024

I think a better approach for this is an option to ignore input outside playfield.

@DeltaFlyerW
Copy link
Contributor Author

I think a better approach for this is an option to ignore input outside playfield.

This may lack of some flexibility. And it requires user to set a smaller playfield which cause anothor UI issue.

@Reco1I
Copy link
Contributor

Reco1I commented Apr 24, 2024

I think a better approach for this is an option to ignore input outside playfield.

This may lack of some flexibility. And it requires user to set a smaller playfield which cause anothor UI issue.

Not necessarily. The main issue with ghost touches is in wide screen devices meanwhile the playfield is (should be) 4:3. And if you ghost touch inside playfield it means skill issue.

@DeltaFlyerW
Copy link
Contributor Author

(#350 (comment))

@Rian8337 Rian8337 linked a pull request May 9, 2024 that will close this issue
Add block area to prevent accidental touch on edge #350
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add block area to prevent accidental touch on edge DeltaFlyerW/osu-droid
2 participants
@DeltaFlyerW @Reco1I