Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

Newer implementations of live preview do not bypass the cache #50

Open
timkelty opened this issue Apr 29, 2021 · 3 comments
Open

Newer implementations of live preview do not bypass the cache #50

timkelty opened this issue Apr 29, 2021 · 3 comments

Comments

@timkelty
Copy link
Collaborator

I think we just need to use getIsPreview instead: https://github.com/craftcms/cms/blob/develop/src/web/Request.php#L690
@ostark
Copy link
Owner

ostark commented Apr 30, 2021

Go ahead, @timkelty, bump the Craft version to ^3.2.1 and use Request::getIsPreview().

@taylordaughtry
Copy link

taylordaughtry commented Dec 13, 2021 •
edited
Loading

@timkelty @ostark Hi! Just bumping this thread—was this solved in some other fashion? Happy to PR this, if it hasn't been tidied up just yet.

@timkelty
Copy link
Collaborator Author

timkelty commented Dec 13, 2021 •
edited
Loading

@taylordaughtry Looks like it hasn't! Send a PR over and I'll merge with a smile.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timkelty @ostark @taylordaughtry