You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a similar issue to what was happening in #142. Tags aren't being managed properly when using embedded structs.
Example from internal/encoding_test.go:
When the Base struct tag is changed from the empty string (such as _id), it fails to be managed correctly with the current version and the ID is lost when calling Convert. This causes the TestNormalize test to fail at line79.
The issue is due to how the createRenameMap function iterates through the fields of the struct. I am submitting a PR that adds a recursive call to the function when the field type is anonymous so the fields of embedded structs will be included.
The text was updated successfully, but these errors were encountered:
This is a similar issue to what was happening in #142. Tags aren't being managed properly when using embedded structs.
Example from
internal/encoding_test.go
:When the
Base
struct tag is changed from the empty string (such as_id
), it fails to be managed correctly with the current version and theID
is lost when callingConvert
. This causes theTestNormalize
test to fail at line79.Adding
json
tags also fails.The issue is due to how the
createRenameMap
function iterates through the fields of the struct. I am submitting a PR that adds a recursive call to the function when the field type is anonymous so the fields of embedded structs will be included.The text was updated successfully, but these errors were encountered: