Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Record scorecard card scans into Rekor #1200

Open
naveensrinivasan opened this issue Oct 30, 2021 · 6 comments
Open

Feature - Record scorecard card scans into Rekor #1200

naveensrinivasan opened this issue Oct 30, 2021 · 6 comments
Assignees
Labels
kind/enhancement New feature or request Stale
Projects

Comments

@naveensrinivasan
Copy link
Member

Is your feature request related to a problem? Please describe.
The scorecard scans should attest that the scan was done to a repository state (commit SHA) or binary release. https://rekor.sigstore.dev https://github.com/sigstore/rekor

@naveensrinivasan naveensrinivasan self-assigned this Oct 30, 2021
@naveensrinivasan naveensrinivasan changed the title Feature - Include scorecard card scans into Rekor Feature - Record scorecard card scans into Rekor Oct 30, 2021
@asraa
Copy link
Contributor

asraa commented Nov 1, 2021

This would be pretty easy to do! do you mean the scorecard scans from the cron jobs?

@naveensrinivasan
Copy link
Member Author

This would be pretty easy to do! do you mean the scorecard scans from the cron jobs?

As of now in the cronjobs later in the GitHub Actions because we can utilize the OIDC Provider in GitHub Actions and probably in cronjob (if not KMS)

Or should we wait for in-toto attestations #1121 (comment) before we do this?

@naveensrinivasan
Copy link
Member Author

in-toto attestations for scans in-toto/attestation#58

@naveensrinivasan
Copy link
Member Author

Question on storing the scorecard scans in rekor .
scorecard uses the Git SHA as the version when performing scans compared to semver for other binary releases.
Does it make sense to utilize in-toto format? If we use the in-toto format for storing scans, how can consumers search for Scorecard scans based on repository and a commit SHA?

https://sigstore.slack.com/archives/C01DGF0G8U9/p1635876627117600?thread_ts=1635628124.084900&cid=C01DGF0G8U9

image

We can use the existing in-toto attestations.

@azeemshaikh38
Copy link
Contributor

@naveensrinivasan are you still working on this?

@justaugustus justaugustus added this to To do in Scorecard Feb 22, 2022
@justaugustus justaugustus moved this from To do to Backlog in Scorecard Feb 22, 2022
Copy link

github-actions bot commented Nov 5, 2023

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the Stale label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request Stale
Projects
Scorecard
Backlog
Status: No status
Development

No branches or pull requests

3 participants