[new] Highway Intersection Check #643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martapako
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
martapako
changed the title
martapako
changed the title
martapako
changed the title
|
@martapako, have you done any analysis on the validity of the flags produced by this check? If you have, it would be great if you could add some stats on what you have done and found to the PR description, similar to the test results section in this PR: #639 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
close #618
The purpose of this check is to flag highways intersecting power or waterway objects.
dam and weir waterway objects are not flagged, these type of waterways can intersect with highways.
for waterway objects the intersection with a highway having leisure=slipway or ford=yes tag is allowed, and they are not flagged.
Potential Impact:
No downstream impact.