Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix Suggestions] One-Member Relation Check #394

Open
ylinzhi opened this issue Oct 19, 2020 · 3 comments
Open

[Fix Suggestions] One-Member Relation Check #394

ylinzhi opened this issue Oct 19, 2020 · 3 comments

Comments

@ylinzhi
Copy link
Contributor

ylinzhi commented Oct 19, 2020

Which Atlas check is the fix suggestion related to?

One-Member Relation Check
Description: https://github.com/osmlab/atlas-checks/blob/dev/docs/checks/oneMemberRelationCheck.md
Script: https://github.com/osmlab/atlas-checks/blob/dev/src/main/java/org/openstreetmap/atlas/checks/validation/relations/OneMemberRelationCheck.java

Describe more details of suggested fix(es)

Suggested Fix 1:

  • Type of fixing: Geometry fix

  • Operation: Delete

  • Suggested Action: Remove the flagged relation

Is there any code enhancement needed if adding the fix suggestion component?

No

@Bentleysb
Copy link
Collaborator

Technically there is no geometry fix needed here, the entire feature is just being deleted.

It might be worth investigating if there are use cases where simply deleting the feature is not the best solution (e.g. a missing member should be added, or some tags should be moved to the member relation), but this seems like a good fix suggestion candidate.

@ladwlo
Copy link
Contributor

ladwlo commented Jan 14, 2021

There are cases such as this island where certain tags should be added to the member Way before removing the redundant relation. I am not sure if this can be generalized enough to be turned into an autofix suggestion. Would it be safe to e.g. include two autofixes here, one to delete the relation and another to add any missing tags to the member way?

@Bentleysb
Copy link
Collaborator

As many suggestions as needed can be included to resolve a problem, as long as we are confident that they are the correct solution. For the island in question I think it would be correct to include a fix suggestion to add tags to the way and another to remove the relation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants