harmonize flags for PHP's htmlspecialchars

lonvia · lonvia · commit cfd631e99cff · 2023-02-20T17:54:38.000+01:00
diff --git a/lib-php/DebugHtml.php b/lib-php/DebugHtml.php
@@ -135,7 +135,7 @@ public static function printGroupTable($sHeading, $aVar)
 
     public static function printSQL($sSQL)
     {
-        echo '<p><tt><font color="#aaa">'.htmlspecialchars($sSQL).'</font></tt></p>'."\n";
+        echo '<p><tt><font color="#aaa">'.htmlspecialchars($sSQL, ENT_QUOTES | ENT_SUBSTITUTE | ENT_HTML401).'</font></tt></p>'."\n";
     }
 
     private static function outputVar($mVar, $sPreNL)
@@ -183,7 +183,7 @@ private static function outputSimpleVar($mVar)
             $sOut = (string)$mVar;
         }
 
-        echo htmlspecialchars($sOut);
+        echo htmlspecialchars($sOut, ENT_QUOTES | ENT_SUBSTITUTE | ENT_HTML401);
         return strlen($sOut);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ public static function printGroupTable($sHeading, $aVar)`
`135`	`135`
`136`	`136`	`public static function printSQL($sSQL)`
`137`	`137`	`{`
`138`		`- echo '<p><tt><font color="#aaa">'.htmlspecialchars($sSQL).'</font></tt></p>'."\n";`
	`138`	`+ echo '<p><tt><font color="#aaa">'.htmlspecialchars($sSQL, ENT_QUOTES \| ENT_SUBSTITUTE \| ENT_HTML401).'</font></tt></p>'."\n";`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`private static function outputVar($mVar, $sPreNL)`
`@@ -183,7 +183,7 @@ private static function outputSimpleVar($mVar)`
`183`	`183`	`$sOut = (string)$mVar;`
`184`	`184`	`}`
`185`	`185`
`186`		`- echo htmlspecialchars($sOut);`
	`186`	`+ echo htmlspecialchars($sOut, ENT_QUOTES \| ENT_SUBSTITUTE \| ENT_HTML401);`
`187`	`187`	`return strlen($sOut);`
`188`	`188`	`}`
`189`	`189`	`}`