Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier support for non-USA (WW) pumps #51

Closed
oskarpearson opened this issue Oct 10, 2016 · 7 comments
Closed

Easier support for non-USA (WW) pumps #51

oskarpearson opened this issue Oct 10, 2016 · 7 comments

Comments

@oskarpearson
Copy link
Owner

Currently it's not easy to use non-USA pumps with Mmeowlink and OpenAPS.

At the moment, I do this manually in my loop, by running mmtune.py --port ${PORT} --serial FIXME --radio_locale WW outside of OpenAPS. Some hacks have been proposed to deal with this, inclduing openaps/oref0#226 (comment)

Additionally, some WW pumps require this process, since the default subg radio settings may need some adjustment: https://github.com/oskarpearson/mmeowlink/wiki/Non-USA-pump-settings

It would be better if:

  • It was easy to add a new device with 'openaps device add pump mmeowlink' and specify the radio locale at the same time.
  • The radio locale would be stored in the pump.ini, and the radio would automatically use it.
  • It was easy to integrate custom radio settings into the mmeowlink tool, since radios vary from user to user.
  • We should default to the parameters in https://github.com/oskarpearson/mmeowlink/wiki/Non-USA-pump-settings as the majority of WW users need them. (This may need to happen as a Pull Request for https://github.com/ps2/subg_rfspy instead)
@oskarpearson
Copy link
Owner Author

I started doing some work on this at https://github.com/oskarpearson/mmeowlink/tree/radio_parameters - but it needs a lot of work, since it predates many other changes. Structurally, though, I like the way we pass/set parameters.

I'll organise to do a rebuild of that tree ASAP

@oskarpearson
Copy link
Owner Author

Related, and which should probably be fixed as part of this change: #16

@PieterGit
Copy link

@oskarpearson : can you tell me what needs to be done, and how you think it's the best way to implement it? I can see if I can help a bit but I don't know what changes you intend to make.

@scottleibrand
Copy link
Collaborator

Anyone have any updates on this? Wondering if we should go ahead and merge openaps/oref0#232, or if there is a reasonable path forward toward doing this right...

@oskarpearson
Copy link
Owner Author

If anyone wants to give this a test on a new box, this will be fixed with:

openaps/openaps#112
openaps/oref0#276
and the dev branch of mmeowlink.

I'll be doing an end-to-end test shortly.

@oskarpearson
Copy link
Owner Author

I've merged the latest changes into master, and built/published a release in preparation of changes to oref0/openaps: mmeowlink 0.10.0

I'm going to leave this open for now - until any issues with those are resolved.

@PieterGit
Copy link

PieterGit commented Dec 29, 2016

@oskarpearson i integrated run subg-ww-radio-parameters script on mmtune
with oref0-setup.sh
Can you review openaps/oref0#282 (already merged to dev)
(especially openaps/oref0@bee2e25 )

I still had a problem with the radio_locale, see #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants