Merge pull request #38 from jaimefps/fix/parseMeta-unstable-split

Split metadata strings on first colon only

Author: goatandsheep

lib/parser.js

@@ -74,7 +74,9 @@ function parse (input, options) {
 function parseMeta (headerParts) {
   const meta = {};
   headerParts.slice(1).forEach(header => {
-    const [key, value] = header.split(':').map(t => t.trim());
+    const splitIdx = header.indexOf(':');
+    const key = header.slice(0, splitIdx).trim();
+    const value = header.slice(splitIdx + 1).trim();
     meta[key] = value;
   });
   return Object.keys(meta).length > 0 ? meta : null;

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "node-webvtt",
-  "version": "1.9.0",
+  "version": "1.9.1",
   "description": "WebVTT parser, compiler, and segmenter with HLS support",
   "main": "index.js",
   "scripts": {

package.json

@@ -454,7 +454,8 @@ Hello world
     const input = {
       meta: {
         Kind: 'captions',
-        Language: 'en'
+        Language: 'en',
+        'X-TIMESTAMP-MAP=LOCAL': '00:00:00.000,MPEGTS:0'
       },
       cues: [{
         end: 140,
@@ -469,6 +470,7 @@ Hello world
     const output = `WEBVTT
 Kind: captions
 Language: en
+X-TIMESTAMP-MAP=LOCAL: 00:00:00.000,MPEGTS:0
 
 1
 00:02:15.001 --> 00:02:20.000

test/compiler.test.js

@@ -299,14 +299,19 @@ Language: en
     const input = `WEBVTT
 Kind: captions
 Language: en
+X-TIMESTAMP-MAP=LOCAL:00:00:00.000,MPEGTS:0
 
 1
 00:00.000 --> 00:00.001`;
     const options = { meta: true };
 
     parse(input, options).should.have.property('valid').be.true;
     parse(input, options).should.have.property('meta').be.deep.equal(
-      { Kind: 'captions', Language: 'en' }
+      {
+        Kind: 'captions',
+        Language: 'en',
+        'X-TIMESTAMP-MAP=LOCAL': '00:00:00.000,MPEGTS:0'
+      }
     );
   });