Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing setup for isolated networks #1728

Open
butler54 opened this issue Oct 16, 2024 · 1 comment · May be fixed by #1729
Open

Testing setup for isolated networks #1728

butler54 opened this issue Oct 16, 2024 · 1 comment · May be fixed by #1729
Assignees
@butler54

Comments

@butler54
Copy link
Collaborator

butler54 commented Oct 16, 2024 •
edited
Loading

Issue description / feature objectives

Today in order to test compliance-trestle the tests include some tests which require access to github. This is driven by profile resolution requirements in a handful (10 or so) tests.

Users w/o direct internet access should be able to run (a subset) of the test suite.

Caveats / Assumptions

The biggest open question here is mocking vs exclusions. In an ideal world we would mock this, however, it might be quite tough to get that right.

Completion Criteria

Users w/o internet access can successfully run the tests.
@butler54
Copy link
Collaborator Author

I've done a partial implementation already where a environmental variable is used to setup an override to skip the tests.

If the team is happy with this, plus documentation, as a stop gap then we are good to go. If we want to enforce mocking then that is another thing.

@butler54 butler54 self-assigned this Oct 19, 2024
@butler54 butler54 linked a pull request Oct 19, 2024 that will close this issue
Draft
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@butler54 butler54

Labels
None yet
Projects
Trestle Roadmap
Status: New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: WIP reinvigoration of package management tooling oscal-compass/compliance-trestle
1 participant
@butler54