Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark identity as optional in session struct #3463

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Aug 29, 2023

The identity is not always available in the session struct, for example when AAL2 is required.

Closes #3461

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #3463 (db92322) into master (dfcbe22) will increase coverage by 0.10%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head db92322 differs from pull request most recent head acca744. Consider uploading reports for the commit acca744 to get more accurate results

@@            Coverage Diff             @@
##           master    #3463      +/-   ##
==========================================
+ Coverage   78.11%   78.21%   +0.10%     
==========================================
  Files         339      339              
  Lines       22463    22463              
==========================================
+ Hits        17547    17570      +23     
+ Misses       3602     3583      -19     
+ Partials     1314     1310       -4     
Files Changed Coverage Δ
session/session.go 78.90% <ø> (ø)

... and 2 files with indirect coverage changes

The identity is not always available in the session struct, for example when AAL2 is required.

Closes #3461
@aeneasr aeneasr merged commit 7ae02ba into master Aug 31, 2023
28 checks passed
@aeneasr aeneasr deleted the close-3461 branch August 31, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nullable identity when logging in with enabled second factor
1 participant