-
-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't require session for OIDC verification #3443
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3443 +/- ##
==========================================
+ Coverage 78.00% 78.04% +0.04%
==========================================
Files 326 327 +1
Lines 21570 21594 +24
==========================================
+ Hits 16826 16854 +28
+ Misses 3488 3482 -6
- Partials 1256 1258 +2
|
64aaf8b
to
b232793
Compare
b232793
to
ca9a2e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I just have some questions on edge cases 👍
...grations/sql/20230818000000000001_verification_add_oauth2_login_challenge_identity_id.up.sql
Outdated
Show resolved
Hide resolved
dee7a93
to
c26f595
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now just some test failures...
c26f595
to
3cd81a9
Compare
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments