Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't require session for OIDC verification #3443

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Aug 18, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from zepatrik August 18, 2023 07:59
@hperl hperl self-assigned this Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #3443 (57a16d5) into master (2f5ba1f) will increase coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 73.07%.

❗ Current head 57a16d5 differs from pull request most recent head 3cd81a9. Consider uploading reports for the commit 3cd81a9 to get more accurate results

@@            Coverage Diff             @@
##           master    #3443      +/-   ##
==========================================
+ Coverage   78.00%   78.04%   +0.04%     
==========================================
  Files         326      327       +1     
  Lines       21570    21594      +24     
==========================================
+ Hits        16826    16854      +28     
+ Misses       3488     3482       -6     
- Partials     1256     1258       +2     
Files Changed Coverage Δ
selfservice/flow/flow.go 100.00% <ø> (ø)
selfservice/strategy/code/strategy_recovery.go 70.56% <0.00%> (ø)
selfservice/strategy/link/strategy_recovery.go 63.33% <0.00%> (ø)
selfservice/flow/verification/fake_strategy.go 40.00% <40.00%> (ø)
driver/registry_default.go 86.68% <60.00%> (-0.34%) ⬇️
selfservice/flow/verification/handler.go 66.20% <90.00%> (+11.05%) ⬆️
driver/registry_default_verification.go 92.00% <100.00%> (ø)
selfservice/flow/registration/flow.go 97.36% <100.00%> (-0.07%) ⬇️
selfservice/flow/verification/flow.go 92.00% <100.00%> (ø)
selfservice/hook/verification.go 77.77% <100.00%> (+1.03%) ⬆️

@hperl hperl force-pushed the hperl/fix-oidc-verification-session branch 3 times, most recently from 64aaf8b to b232793 Compare August 20, 2023 11:10
@hperl hperl requested review from alnr and jonas-jonas August 20, 2023 11:11
@hperl hperl marked this pull request as ready for review August 20, 2023 11:11
@hperl hperl requested a review from aeneasr as a code owner August 20, 2023 11:11
@hperl hperl changed the title hperl/fix-oidc-verification-session fix: don't require session for OIDC verification Aug 21, 2023
@hperl hperl force-pushed the hperl/fix-oidc-verification-session branch from b232793 to ca9a2e6 Compare August 21, 2023 07:06
jonas-jonas
jonas-jonas previously approved these changes Aug 21, 2023
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I just have some questions on edge cases 👍

@hperl hperl force-pushed the hperl/fix-oidc-verification-session branch 2 times, most recently from dee7a93 to c26f595 Compare August 21, 2023 10:33
@hperl hperl requested a review from zepatrik August 21, 2023 10:33
zepatrik
zepatrik previously approved these changes Aug 21, 2023
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now just some test failures...

@zepatrik zepatrik merged commit e08f831 into master Aug 22, 2023
28 checks passed
@zepatrik zepatrik deleted the hperl/fix-oidc-verification-session branch August 22, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants