Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update correct typo #3281

Merged
merged 3 commits into from
Jul 11, 2023
Merged

fix: update correct typo #3281

merged 3 commits into from
Jul 11, 2023

Conversation

giautm
Copy link
Contributor

@giautm giautm commented May 15, 2023

The text for verification code input should be Verification code not Verify code.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@CLAassistant
Copy link

CLAassistant commented May 15, 2023

CLA assistant check
All committers have signed the CLA.

@giautm giautm changed the title text: update correct typo fix(verification): update correct typo May 15, 2023
@giautm giautm changed the title fix(verification): update correct typo fix: update correct typo May 15, 2023
@giautm giautm marked this pull request as ready for review May 15, 2023 12:55
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #3281 (6e36e28) into master (8f9bff5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 6e36e28 differs from pull request most recent head f50c794. Consider uploading reports for the commit f50c794 to get more accurate results

@@            Coverage Diff             @@
##           master    #3281      +/-   ##
==========================================
+ Coverage   78.01%   78.02%   +0.01%     
==========================================
  Files         327      327              
  Lines       21284    21296      +12     
==========================================
+ Hits        16604    16616      +12     
  Misses       3447     3447              
  Partials     1233     1233              
Impacted Files Coverage Δ
cmd/clidoc/main.go 68.34% <100.00%> (+0.29%) ⬆️
selfservice/strategy/code/strategy_recovery.go 70.56% <100.00%> (ø)
selfservice/strategy/code/strategy_verification.go 74.25% <100.00%> (ø)
text/message_node.go 100.00% <100.00%> (ø)

jonas-jonas
jonas-jonas previously approved these changes May 16, 2023
Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great change.

@giautm
Copy link
Contributor Author

giautm commented May 21, 2023

Hello @jonas-jonas, can we merge this soon?

Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looking at this close, we also use this label for recovery, where "Verification code" would not be the right term. But we use one label for both. This would be a breaking change.

WDYT @aeneasr?

@aeneasr
Copy link
Member

aeneasr commented May 24, 2023

In that case we indeed need to split the text message and introduce a new message ID. I think that's fine in terms of backwards compatibility

@aeneasr
Copy link
Member

aeneasr commented May 24, 2023

@jonas-jonas could you quickly do that?

@jonas-jonas
Copy link
Member

@aeneasr done.

@giautm we're using the "Verify Code" label during the MFA (via TOTP) setup as well, so I reverted the renaming and added new nodes for verification & recovery. Thanks again for spotting & fixing this!

giautm and others added 3 commits July 6, 2023 15:23
The text for verification code input should be `Verification code` not `Verify code`.
Signed-off-by: Giau. Tran Minh <[email protected]>
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit 0fea75c into ory:master Jul 11, 2023
25 checks passed
@giautm giautm deleted the patch-1 branch July 12, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants