Oathkeeper tries to install CRDs even when maester is disabled

[codesavvy-nl]

Describe the bug

When setting maester.enabled=false Oathkeeper stills wants to install CRDs.

To Reproduce

Steps to reproduce the behavior:

Edit values.yaml or use --set

Expected behavior

I expected CRDs not be installed.

Environment

• Helm: version.BuildInfo{Version:"v3.5.3", GitCommit:"041ce5a2c17a58be0fcd5f5e16fb3e7e95fea622", GitTreeState:"dirty", GoVersion:"go1.16"}
• Environment: MacOS 11.2.3

Additional context

Cloning this repo and manually removing maester.tgz from the charts folder allowed me to deploy.

[aeneasr]

What chart version are you using?

[codesavvy-nl]

What chart version are you using?

0.7.0

[Demonsthere]

Hello there
I'm trying to reproduce the issue by installing the chart from my local repo:

 helm install oathkeeper ./helm/charts/oathkeeper -f local/oathkeeper.yaml --debug
 cat local/oathkeeper.yaml
---
maester:
  enabled: false
demo: true

In the result I see that, you are right, the CRDs are installed, which is a result of #235 and moving them to the crds folder. However, I don't see the controller installed, only its CRDs.

[codesavvy-nl]

The CRDs is what was giving me the issue, since I'm not a cluster-admin trying to install gave me an error.
I have updated the issue

[Demonsthere]

I see, after some looking around, it seems this is a known helm bug

[aeneasr]

Right, I remember. I don’t think there’s a workaround - the upstream issue has not seen progress so this is a cantfix for us :/

[Demonsthere]

The workaround was to have the CRDs be installed in a different way, as we had before. However, that came with its own problems :<. TBH there isn't a Good way to do it :/

[aeneasr]

Yeah, maybe it's time to move to a jsonnet approach at some point...