-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DynamoDB preset #53
Comments
Hi, Can I work on this issue? |
Hi, @imsk17! Of course. Thank you! |
it seems this isn't easy. dynamodb requires structs before it makes a table. so u cannot use map[string]interface{} |
@imsk17, that's fine! What do you think about narrowing the scope of this issue to implementing a preset that only has a working healthcheck function? If in the future somebody requests initial setup, we handle it then. |
or maybe we can setup a withStructs() method? |
I think it would complicate the development too much for the value it provides. If you'd like to work on initial data setup in dynamodb, I'd recommend to work on it as an independent task right after we merge a minimal working preset. |
okay! thats fine |
@imsk17 Are you still working on this? |
quite busy nowadays. you can do it if you want to |
@orlangure |
@nawa, Another factor is the API. Take Localstack S3 for example. We have The third factor which I'm not entirely sure about is startup speed. I assume that starting Localstack would take more time than just a DynamoDB container. But I'm of course glad that there is an option to use DynamoDB via Localstack even though there are no initial state setup features like with other databases. |
A short guide on implementing a new preset:
https://github.com/orlangure/gnomock/blob/master/CONTRIBUTING.md#new-presets
MySQL preset for inspiration:
https://github.com/orlangure/gnomock/tree/master/preset/mysql
The objective is to implement a new Preset that spins up DynamoDB docker container, sets up its initial state (user provided data), waits for it to become ready and kills it in the end.
Please note that there are multiple steps required to create a new preset (see the guide above).
I'm here to help😼
The text was updated successfully, but these errors were encountered: