Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unexpected Row Height increasing In IE11 #426

Open
jonirrings opened this issue Apr 24, 2019 · 2 comments
Open

unexpected Row Height increasing In IE11 #426

jonirrings opened this issue Apr 24, 2019 · 2 comments

Comments

@jonirrings
Copy link

jonirrings commented Apr 24, 2019 •
edited

this bug only occurs in IE
put this in gridx/tests/

<!DOCTYPE html>
<html>
<head>
	<title>GridX Row Height Expanding Bug</title>
	<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
	<link rel='stylesheet' href="support/common.css" />
	<script type="text/javascript" src="../../dojo/dojo.js" data-dojo-config="async: true"></script>
	<script type="text/javascript" src='support/common.js'></script>
	<script type="text/javascript" src='test_grid_edit.js'></script>
	<style type="text/css">
		.gridx {
			width: 1000px;
			height: 400px;
			margin-bottom: 20px;
		}
	</style>
</head>
<body class='claro'>
	<h1 class='title' tabindex='0' onfocus='this.style.color="blue"' onblur='this.style.color=""'>
		GridX Row Height Expanding Bug
	</h1>
	<p>This is adapted from test_grid_edit, works well under 1.2.1, but buggy under 1.3.8</p>
	<p>Double click or press ENTER on a cell to edit</p>
	<h2>Dijit as editor</h2>
	<div jsid='grid1' data-dojo-type='gridx.Grid' data-dojo-props='
		cacheClass: "gridx/core/model/cache/Sync",
		store: store1,
		structure: layout1,
		columnLockCount: 1,
		modules: [
            "gridx/modules/ColumnLock",
			"gridx/modules/RowHeader",
			"gridx/modules/IndirectSelect",
			"gridx/modules/extendedSelect/Row",
			"gridx/modules/VirtualVScroller",
			"gridx/modules/CellWidget",
			"gridx/modules/Edit",
			"gridx/modules/Pagination",
			"gridx/modules/pagination/PaginationBar"
		]
	'></div>
	<h2>Custom editor</h2>
	<div jsid='grid2' data-dojo-type='gridx.Grid' data-dojo-props='
		cacheClass: "gridx/core/model/cache/Sync",
		store: store2,
		structure: layout2,
		modules: [
			"gridx/modules/CellWidget",
			"gridx/modules/Edit"
		]
	'></div>
</body>
</html>

once a table cell transform into a Widget Editor, the height of every row (even the header row) increased.

this bug can be reproduced under gridx version 1.3.8, but not under 1.2.1.

anybody got any solution?
@jonirrings jonirrings changed the title unexpected Row Height increasing unexpected Row Height increasing In IE11 Apr 24, 2019
@jonirrings
Copy link
Author

the mimial modules required to reproduce this bug are ["gridx/modules/ColumnLock","gridx/modules/CellWidget","gridx/modules/Edit"]

@jonirrings
Copy link
Author

in case that too many data will slow down IE11, you could reduce the data in store1 to size 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonirrings