-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make the plz
menu configurable via the config file
#96
Comments
am available to work on this feature btw |
for the next major version, I know that you probably wanted to make it after #56 gets merged and I probably caused to delay. am sorry for that but I guess that is better if we just release a minor version for now to bush all the bug fixes and the simi features that have been added (if we can say) to push it to the users, and we can continue to work on #56 or implementing this request |
Hmm, I didn't quite get what's wrong with #56, it can still be implemented and we can make it configurable in the future.
Sounds reasonable. Do you think we can go with |
sounds reasonable, in this case, I think that #56 is ready to review, and I can start to work on this after it gets merged
I think it's time for, we did a much work since 0.1.7 |
Alrighty, I will add a review soon, feel free to mark it as non-draft :3 |
by the way, if #56 gets merged then we'll probably have to change the CLI interface and remove the added options when we work on this feature |
Then the release can wait until that's done? |
I think so, the current version works just fine(in most cases) and we don't really want frequently break the users' workflow by changing our command-line interface. (at least if we know that we'll remove those changes in the next version) |
Okay sounds good. |
#56 is now merged 🥳 We can proceed with the next steps when you have time! |
Great, can you assign this issue to me so? |
You got it! |
while working on #56 (to add more help providers), I realized that we (or I) are doing this the wrong way. the user may agree or disagree with our choices and we have to provide an easy way for the user to change the
plz
menu elements as he/she wanted not as we wantDescribe the solution you'd like
Instead, we can read a 2D array from the user via the config file or the CLI arguments, or both. this array contains the
plz
menu elements in the same order that we going to display with, the elements of this array will be in this form:OR something similar
Additional context
if we started to work on this I'll close feat(helper): add more external help providers to plz menu #56the PR that'll close this probably will close Add the ability to use more types of manuals/cheatsheets #14 tooThe text was updated successfully, but these errors were encountered: