Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last use of Parboiled 1 #5000

Open
2 tasks
ebruchez opened this issue Sep 16, 2021 · 2 comments
Open
2 tasks

Remove last use of Parboiled 1 #5000

ebruchez opened this issue Sep 16, 2021 · 2 comments
Assignees

Comments

@ebruchez
Copy link
Collaborator

ebruchez commented Sep 16, 2021

We have already migrated to Parboiled 2 for the process parser. We need to do the same for CSSSelectorParser.

  • update CSSSelectorParser
  • remove dependency
@ebruchez
Copy link
Collaborator Author

Noting, based on this thread, that Parboiled 2 for Scala 3 is not quite a given. There is a Scala 3 branch (sirthias/parboiled2#280 at the time of writing), but no published version yet, and several remaining issues. However, there are a few mainstream uses of Parboiled 2 so it seems that this will eventually happen.

See also https://github.com/typelevel/cats-parse.

@ebruchez
Copy link
Collaborator Author

Parboiled 2 is available for Scala 3 since February 2022.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant