Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.sh script to use longer template name #762

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ProbstenHias
Copy link

@ProbstenHias ProbstenHias commented Apr 12, 2024

Using the install.sh script fails on alpine distributions as the installed mktemp tool on alpine expects at least 6 X when creating a temp folder with a template.

According to the tool installed on alpine

ecc23e77fdf2:/# mktemp --help
BusyBox v1.36.1 (2023-11-07 18:53:09 UTC) multi-call binary.

Usage: mktemp [-dt] [-p DIR] [TEMPLATE]

Create a temporary file with name based on TEMPLATE and print its name.
TEMPLATE must end with XXXXXX (e.g. [/dir/]nameXXXXXX).
Without TEMPLATE, -t tmp.XXXXXX is assumed.
...

For that reason the install script fails on alpine with the error

mktemp: Invalid argument

This PR fixes the issue by adding two more x 😀

Fixes #767

Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Apr 12, 2024
@ProbstenHias ProbstenHias force-pushed the fix_install_script_for_alpine branch from 9bb7d1d to 43252b8 Compare April 12, 2024 13:26
@ProbstenHias ProbstenHias force-pushed the fix_install_script_for_alpine branch from 43252b8 to c55e0e6 Compare April 12, 2024 13:36
@ProbstenHias
Copy link
Author

Agreement is under review 👍🏻

Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCI CLI install.sh fails on Alpine
1 participant