chore: add config variable to defaults.ini and minor cleanup

Signed-off-by: Amine <[email protected]>

Author: AmineRaouane

.gitignore

@@ -181,4 +181,4 @@ docs/_build
 bin/
 requirements.txt
 .macaron_env_file
-**/.DS_Store
+.DS_Store

src/macaron/config/defaults.ini

@@ -600,3 +600,5 @@ major_threshold = 20
 epoch_threshold = 3
 # The number of days +/- the day of publish the calendar versioning day may be.
 day_publish_error = 4
+# THe threshold for the number of repeated spaces in a line from the source code.
+repeated_spaces_threshold =

src/macaron/malware_analyzer/pypi_heuristics/sourcecode/white_spaces.py

@@ -48,11 +48,16 @@ def _load_defaults(self) -> int:
             The repeated spaces threshold.
         """
         section_name = "heuristic.pypi"
+        default_threshold = 50
+
         if defaults.has_section(section_name):
             section = defaults[section_name]
-            return section.getint("repeated_spaces_threshold", 50)
+            value_str = section.get("repeated_spaces_threshold", fallback=str(default_threshold))
+            if value_str is not None and value_str.isdigit():
+                return int(value_str)
+            return default_threshold
 
-        return 50
+        return default_threshold
 
     def analyze(self, pypi_package_json: PyPIPackageJsonAsset) -> tuple[HeuristicResult, dict[str, JsonType]]:
         """Analyze the package.

src/macaron/slsa_analyzer/checks/detect_malicious_metadata_check.py

@@ -385,7 +385,7 @@ def run_check(self, ctx: AnalyzeContext) -> CheckResultData:
 
     % Package released with excessive whitespace in the code .
     {Confidence.HIGH.value}::trigger(malware_high_confidence_4) :-
-        quickUndetailed, forceSetup, failed({Heuristics.WHITE_SPACES.value}).
+        forceSetup, failed({Heuristics.WHITE_SPACES.value}).
 
     % Package released recently with little detail, with multiple releases as a trust marker, but frequent and with
     % the same code.