remove AnalysisError.shouldNotReachHere() without message

Author: wirthi

substratevm/src/com.oracle.graal.pointsto/src/com/oracle/graal/pointsto/flow/ProxyTypeFlow.java

@@ -60,17 +60,17 @@ public TypeFlow<?> getInput() {
 
     @Override
     public boolean addState(PointsToAnalysis bb, TypeState add) {
-        throw AnalysisError.shouldNotReachHere();
+        throw AnalysisError.shouldNotReachHere("should not be reached during analysis");
     }
 
     @Override
     public void update(PointsToAnalysis bb) {
-        throw AnalysisError.shouldNotReachHere();
+        throw AnalysisError.shouldNotReachHere("should not be reached during analysis");
     }
 
     @Override
     public TypeState getState() {
-        throw AnalysisError.shouldNotReachHere();
+        throw AnalysisError.shouldNotReachHere("should not be reached during analysis");
     }
 
     @Override

substratevm/src/com.oracle.graal.pointsto/src/com/oracle/graal/pointsto/flow/context/bytecode/TypesObjectsIterator.java

@@ -84,7 +84,7 @@ private static AnalysisObject[] objectsArray(TypeState state) {
         if (state instanceof ContextSensitiveMultiTypeState) {
             return ((ContextSensitiveMultiTypeState) state).objects;
         }
-        throw AnalysisError.shouldNotReachHere();
+        throw AnalysisError.shouldNotReachHereUnexpectedInput(state);
     }
 
     /**

substratevm/src/com.oracle.graal.pointsto/src/com/oracle/graal/pointsto/meta/AnalysisMetaAccess.java

@@ -90,12 +90,12 @@ public AnalysisField lookupJavaField(Field reflectionField) {
 
     @Override
     public int getArrayIndexScale(JavaKind elementKind) {
-        throw shouldNotReachHere();
+        throw shouldNotReachHere("should not be reached during analysis");
     }
 
     @Override
     public int getArrayBaseOffset(JavaKind elementKind) {
-        throw shouldNotReachHere();
+        throw shouldNotReachHere("should not be reached during analysis");
     }
 
     @Override

substratevm/src/com.oracle.graal.pointsto/src/com/oracle/graal/pointsto/meta/UninitializedStaticFieldValueReader.java

@@ -119,7 +119,7 @@ public static JavaConstant readUninitializedStaticValue(ResolvedJavaField field,
                 assert value == null || value instanceof String : "String is currently the only specified object type for the ConstantValue class file attribute";
                 return function.apply(value);
             default:
-                throw AnalysisError.shouldNotReachHere();
+                throw AnalysisError.shouldNotReachHereUnexpectedInput(kind);
         }
     }
 }

substratevm/src/com.oracle.graal.pointsto/src/com/oracle/graal/pointsto/typestate/DefaultAnalysisPolicy.java

@@ -201,7 +201,7 @@ public MethodFlowsGraphInfo staticRootMethodGraph(PointsToAnalysis bb, PointsToA
 
     @Override
     public AnalysisContext allocationContext(PointsToAnalysis bb, MethodFlowsGraph callerGraph) {
-        throw AnalysisError.shouldNotReachHere();
+        throw AnalysisError.shouldNotReachHere("should be overwritten");
     }
 
     @Override

substratevm/src/com.oracle.graal.pointsto/src/com/oracle/graal/pointsto/util/AnalysisError.java

@@ -157,8 +157,8 @@ public static FieldNotPresentError fieldNotPresentError(PointsToAnalysis bb, Typ
         throw new FieldNotPresentError(bb, objectFlow, context, field, type);
     }
 
-    public static RuntimeException shouldNotReachHere() {
-        throw new AnalysisError("should not reach here");
+    public static RuntimeException shouldNotReachHereUnexpectedInput(Object input) {
+        throw new AnalysisError("should not reach here: unexpected input: " + input);
     }
 
     public static RuntimeException shouldNotReachHere(String msg) {