Adress reviewer comments.

Author: chumer

truffle/CHANGELOG.md

@@ -27,7 +27,7 @@ This changelog summarizes major changes between Truffle versions relevant to lan
 * GR-69649: Bytecode DSL now encodes primitive constant operands directly in the bytecode, reducing memory indirections in the interpreter. This optimization is enabled by default; you can configure it with `@GenerateBytecode(inlinePrimitiveConstants = true)`.
 * GR-68993: Added `HostCompilerDirectives.markThreadedSwitch(int)` to mark a switch statement within a loop as a candidate for threaded switch optimization.
 * GR-68993: Bytecode DSL: All bytecode interpreters are now using the threaded switch optimization by default. This new optimization can be configured using `@GenerateBytecode(enableThreadedSwitch=true|false)`.
-* GR-71030: Bytecode DSL now generates a new `MyBytecodeRootNodeGen.Bytecode` class that can be accessed via the `MyBytecodeRootNodeGen.BYTECODE` singleton. This class which extends the added `ByteccodeDescriptor` allows you to parse, serialize and deserialize bytecode nodes in addition to the already existing static methods in the generated code.
+* GR-71030: Bytecode DSL now generates a new `MyBytecodeRootNodeGen.Bytecode` class that can be accessed via the `MyBytecodeRootNodeGen.BYTECODE` singleton. This class which extends the added `BytecodeDescriptor` allows you to parse, serialize and deserialize bytecode nodes in addition to the already existing static methods in the generated code.
 * GR-71030: Bytecode DSL now provides an `InstructionDescriptor` generated implementation for the bytecode interpreter. The instructions can be accessed via the new BytecodeDescriptor like this: `MyBytecodeRootNodeGen.BYTECODE.getInstructionDescriptors()`. There is also `MyBytecodeRootNodeGen.BYTECODE.dump()` to produce a human-readable instruction format.
 * GR-71031: Added new method `BytecodeDescriptor.update(MyLanguage, BytecodeConfig)` to update the bytecode config for all current root nodes and root nodes created in the future of a language.
 * GR-51945: Bytecode DSL, added `InstructionTracer` with `onInstructionEnter(InstructionAccess, BytecodeNode, int, Frame)`. Tracers can be attached per root via `BytecodeRootNodes.addInstructionTracer(InstructionTracer)` and per descriptor via `BytecodeDescriptor.addInstructionTracer(TruffleLanguage, InstructionTracer)`. Attaching a tracer invalidates affected roots and may trigger reparse and comes at a significant cost.

truffle/src/com.oracle.truffle.api.bytecode.test/src/com/oracle/truffle/api/bytecode/test/basic_interpreter/BasicInterpreterTest.java

@@ -48,7 +48,6 @@
 import static org.junit.Assert.assertThrows;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
-import static org.junit.Assume.assumeFalse;
 import static org.junit.Assume.assumeTrue;
 
 import java.util.ArrayList;

truffle/src/com.oracle.truffle.api.bytecode/src/com/oracle/truffle/api/bytecode/BytecodeDescriptor.java

@@ -79,7 +79,7 @@
  * default implementation throws {@link UnsupportedOperationException}.
  *
  * <li><strong>Describing the instruction set:</strong> {@link #getInstructionDescriptors()} and
- * {@link #getInstructionDescriptor(int)} expose all instruction kinds, including normal language
+ * {@link #getInstructionDescriptor(int)} expose all instructions, including normal language
  * operations and injected instrumentation instructions. The descriptor can also produce a human
  * readable dump via {@link #dump()}.
  *
@@ -141,7 +141,7 @@
  * Object result = root.getCallTarget().call(42);
  * }</pre>
  *
- * @param <R> the {@link #getSpecificationClass() specificiation class}, which is both a
+ * @param <R> the {@link #getSpecificationClass() specification class}, which is both a
  *            {@link RootNode} and a {@link BytecodeRootNode}
  * @param <L> the Truffle language type
  * @param <B> the builder type used to emit bytecode for this interpreter
@@ -197,7 +197,7 @@ protected BytecodeDescriptor(Object token) {
     /**
      * Returns an immutable list of all instruction descriptors known to this interpreter. The list
      * describes every instruction kind that can be executed by nodes generated from this
-     * descriptor.
+     * interpreter.
      *
      * @since 25.1
      */

truffle/src/com.oracle.truffle.api.bytecode/src/com/oracle/truffle/api/bytecode/Instruction.java

@@ -103,7 +103,7 @@ protected Instruction(Object token) {
     /**
      * Returns the descriptor object for this instruction.
      * <p>
-     * The descriptor provides static metadata about the instruction kind executed at this bytecode
+     * The descriptor provides static metadata about the instruction executed at this bytecode
      * index, such as its name, operation code, length in bytes, argument layout, and whether it is
      * considered instrumentation.
      *
@@ -360,9 +360,8 @@ protected Argument(Object token) {
          * Returns the descriptor object for this argument.
          * <p>
          * The descriptor provides static metadata about the argument position and interpretation
-         * for this instruction kind, including its {@link Kind}, printable name, and encoded width
-         * in bytes. This metadata is the same for all arguments in the same instruction slot for
-         * the same instruction kind.
+         * for this instruction, including its {@link Kind}, printable name, and encoded width in
+         * bytes.
          *
          * @since 25.1
          */