Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: positions page redesign #973

Open
wants to merge 33 commits into
base: fix/faq-link
Choose a base branch
from
Open

style: positions page redesign #973

wants to merge 33 commits into from

Conversation

nikkaroraa
Copy link
Member

@nikkaroraa nikkaroraa commented Feb 6, 2023 •
edited
Loading

Task

Fixes ENG-1462

Merge Instructions

Please merge after #976

@vercel
Copy link

vercel bot commented Feb 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
continuouscall ✅ Ready (Inspect) Visit Preview ✅ 1 resolved Feb 13, 2023 at 0:23AM (UTC)

@nikkaroraa nikkaroraa force-pushed the style/positions-redesign branch from ba0aec9 to 8ddd8c2 Compare February 7, 2023 18:01
@linear
Copy link

linear bot commented Feb 8, 2023

ENG-1462 /positions page redesign

changes:

  • use monospace font for numbers
  • fix alignment issues with the tooltip
  • improve ui when wallet is not connected

@nikkaroraa nikkaroraa changed the title style: positions page redesign [wip] style: positions page redesign Feb 8, 2023
@nikkaroraa nikkaroraa requested review from KMKoushik and alexisgauba and removed request for KMKoushik February 8, 2023 12:17
@nikkaroraa
style: positions page ui
8b6a4cd
@nikkaroraa
style: your vaults ui
2ac0520
@nikkaroraa
style: update backgroundColor
5fbf1fc
@nikkaroraa
fix: fix undefined vault
60ac49b
@nikkaroraa
refactor: rename History to TxHistory
7e6c130
@nikkaroraa
style: add a small loading placeholder
2634c60
@nikkaroraa
refactor: move into separate components for readability
0bd5fd7
@nikkaroraa
feat: headerbar to show connected wallet status
912204e
@nikkaroraa
feat: show eth denominated value for legacy users
7ff05b2
@nikkaroraa
refactor: use the common Loading component
23cd2e7
@nikkaroraa
style: use textSecondary color for loading and empty text
97623d3
@nikkaroraa
style: use monospace font for eth denominated crab value
ccd7eaf
@nikkaroraa
fix: fix typo
4537694
@nikkaroraa
style: tx history responsiveness
17f472d
@nikkaroraa
style: increase position title's font weight
35d4524
@nikkaroraa
style: format squeethAmount to 4 digits
6dd506a
@nikkaroraa
fix: keep using iconbutton
d66c452
@nikkaroraa
style: final style changes for responsiveness
ed598b6
@nikkaroraa
feat: add links to open position when none
c245322
@nikkaroraa nikkaroraa force-pushed the style/positions-redesign branch from ee725a0 to c245322 Compare February 13, 2023 12:18
@nikkaroraa nikkaroraa mentioned this pull request Feb 13, 2023
Open
@nikkaroraa nikkaroraa changed the base branch from main to fix/faq-link February 13, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexisgauba alexisgauba Awaiting requested review from alexisgauba

@KMKoushik KMKoushik Awaiting requested review from KMKoushik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nikkaroraa