Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unstable/inflated unrealised pnl issues #347

Closed
wants to merge 60 commits into from
Closed

Fix unstable/inflated unrealised pnl issues #347

wants to merge 60 commits into from

Conversation

EstherSeyi
Copy link
Contributor

@EstherSeyi EstherSeyi commented Apr 13, 2022 •
edited
Loading

Task:

Description

  • Replaces vault manager subscription with polling to ensure that vault data is always updated.
  • Replaces swaps data with swaps atom in computeSwaps provider to ensure that squeethAmount is always updated for pnl calculation.
  • Removes swaps query subscription as it didn't seem to work and was causing bug of swaps being empty array sometimes.
  • Adds unit tests for unrealized pnl calculations. Run test with: yarn test pnl

Fixes # (issue)
#350

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document update

How Has This Been Tested

You can test by seeing if you experience loading issues or incorrect pnl. see this doc for the unrealized pnl formulas.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Added video recordings if it is a UI change

@vercel
Copy link

vercel bot commented Apr 13, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/opynfinance/continuouscall/CaqYwbassRq9mAi9uPVQhivDN6eY
✅ Preview: https://continuouscall-git-fe-unrealized-pnl-issues-opynfinance.vercel.app

@EstherSeyi EstherSeyi marked this pull request as ready for review April 13, 2022 21:16
@KMKoushik
Copy link
Contributor

@EstherSeyi How do I test these and are there any issues created for this?

@EstherSeyi
Copy link
Contributor Author

EstherSeyi commented Apr 14, 2022 •
edited
Loading

@EstherSeyi How do I test these and are there any issues created for this?

Yes I just created an issue. I think you can just watch and calculate the pnl to see that it's correct. Doc with formulas

@vercel
Copy link

vercel bot commented Apr 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
continuouscall ✅ Ready (Inspect) Visit Preview May 4, 2022 at 0:28AM (UTC)

@EstherSeyi EstherSeyi linked an issue Apr 20, 2022 that may be closed by this pull request
Unrealized pnl issues #350
Open
KMKoushik
KMKoushik suggested changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@KMKoushik KMKoushik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My tx history is gone

preview:
Screen Shot 2022-04-27 at 9 18 59 am

Prod
Screen Shot 2022-04-27 at 9 19 38 am

Similarly my long position is also not shown

@EstherSeyi
Copy link
Contributor Author

continuouscall-git-fe-unrealized-pnl-issues-opynfinance.vercel.app

My tx history is gone

Similarly my long position is also not shown

@KMKoushik was there any error on your console

@KMKoushik
Copy link
Contributor

continuouscall-git-fe-unrealized-pnl-issues-opynfinance.vercel.app

My tx history is gone

Similarly my long position is also not shown

@KMKoushik was there any error on your console

Nothing new @EstherSeyi
Screen Shot 2022-04-27 at 8 58 40 pm

@EstherSeyi EstherSeyi force-pushed the fe/unrealized-pnl-issues branch from 4ade0cc to 53ee369 Compare May 2, 2022 11:46
@EstherSeyi EstherSeyi requested a review from KMKoushik May 2, 2022 17:20
@KMKoushik
Copy link
Contributor

@EstherSeyi Still getting the same issue. Seems to be working in ropsten but not in mainnet. I pinged you with the wallet address

@KMKoushik
Copy link
Contributor

Need to be merged after we fix positions completely

@KMKoushik KMKoushik closed this Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@block902 block902 Awaiting requested review from block902

@deepthinker250 deepthinker250 Awaiting requested review from deepthinker250

@yichiehliu yichiehliu Awaiting requested review from yichiehliu

@KMKoushik KMKoushik Awaiting requested review from KMKoushik

Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unrealized pnl issues Short position card pnl keeps showing loading state
4 participants
@EstherSeyi @KMKoushik @yichiehliu @deepthinker250