handle empty nodes, chunk eval requests (#2556)

Author: Alexandre-Herve

package.json

@@ -2,7 +2,7 @@
   "name": "openapi-workspaces",
   "license": "MIT",
   "private": true,
-  "version": "0.53.3",
+  "version": "0.53.4",
   "workspaces": [
     "projects/json-pointer-helpers",
     "projects/openapi-io",

projects/fastify-capture/package.json

@@ -2,7 +2,7 @@
   "name": "@useoptic/fastify-capture",
   "license": "MIT",
   "packageManager": "[email protected]",
-  "version": "0.53.3",
+  "version": "0.53.4",
   "main": "build/index.js",
   "types": "build/index.d.ts",
   "files": [

projects/json-pointer-helpers/package.json

@@ -2,7 +2,7 @@
   "name": "@useoptic/json-pointer-helpers",
   "license": "MIT",
   "packageManager": "[email protected]",
-  "version": "0.53.3",
+  "version": "0.53.4",
   "main": "build/index.js",
   "types": "build/index.d.ts",
   "files": [

projects/openapi-io/package.json

@@ -2,7 +2,7 @@
   "name": "@useoptic/openapi-io",
   "license": "MIT",
   "packageManager": "[email protected]",
-  "version": "0.53.3",
+  "version": "0.53.4",
   "main": "build/index.js",
   "types": "build/index.d.ts",
   "files": [

projects/openapi-utilities/package.json

@@ -2,7 +2,7 @@
   "name": "@useoptic/openapi-utilities",
   "license": "MIT",
   "packageManager": "[email protected]",
-  "version": "0.53.3",
+  "version": "0.53.4",
   "main": "build/index.js",
   "types": "build/index.d.ts",
   "files": [

projects/optic/package.json

@@ -2,7 +2,7 @@
   "name": "@useoptic/optic",
   "license": "MIT",
   "packageManager": "[email protected]",
-  "version": "0.53.3",
+  "version": "0.53.4",
   "main": "build/index.js",
   "types": "build/index.d.ts",
   "files": [

projects/rulesets-base/package.json

@@ -2,7 +2,7 @@
   "name": "@useoptic/rulesets-base",
   "license": "MIT",
   "packageManager": "[email protected]",
-  "version": "0.53.3",
+  "version": "0.53.4",
   "main": "build/index.js",
   "types": "build/index.d.ts",
   "files": [

projects/standard-rulesets/package.json

@@ -2,7 +2,7 @@
   "name": "@useoptic/standard-rulesets",
   "license": "MIT",
   "packageManager": "[email protected]",
-  "version": "0.53.3",
+  "version": "0.53.4",
   "main": "build/index.js",
   "types": "build/index.d.ts",
   "files": [

projects/standard-rulesets/src/lintgpt/index.ts

@@ -233,7 +233,7 @@ export class LintGpt extends ExternalRuleBase {
         const eval_data = {
           rule_checksum,
           location_context: operation.locationContext,
-          node: stableStringify(operation.value),
+          node: stableStringify(operation.value ?? ''),
           node_before: stableStringify(operation.before ?? ''),
         };
         const node_checksum = computeNodeChecksum(eval_data);
@@ -249,7 +249,7 @@ export class LintGpt extends ExternalRuleBase {
         const eval_data = {
           rule_checksum,
           location_context: response.locationContext,
-          node: stableStringify(response.value),
+          node: stableStringify(response.value ?? ''),
           node_before: stableStringify(response.before ?? ''),
         };
         const node_checksum = computeNodeChecksum(eval_data);
@@ -265,7 +265,7 @@ export class LintGpt extends ExternalRuleBase {
         const eval_data = {
           rule_checksum,
           location_context: property.locationContext,
-          node: stableStringify(property.value),
+          node: stableStringify(property.value ?? ''),
           node_before: stableStringify(property.before ?? ''),
         };
         const node_checksum = computeNodeChecksum(eval_data);

projects/standard-rulesets/src/lintgpt/rules-helper.ts

@@ -260,9 +260,12 @@ export class LintgptRulesHelper {
           const evalsToRequest = requestsWithoutEvals.map(
             (r) => r.eval_request
           );
-          await this.client.requestLintgptEvals(evalsToRequest);
+          const evalsToRequestChunks = chunk(evalsToRequest, 20);
+          for (const chunk of evalsToRequestChunks) {
+            await this.client.requestLintgptEvals(chunk);
+            await new Promise((resolve) => setTimeout(resolve, 20));
+          }
         }
-
         firstRun = false;
       }
 
@@ -288,7 +291,11 @@ export class LintgptRulesHelper {
 }
 
 export const computeRuleChecksum = (rule: string): string =>
-  crypto.createHash('sha256').update(rule).digest('base64').toString();
+  crypto
+    .createHash('sha256')
+    .update(rule ?? '')
+    .digest('base64')
+    .toString();
 
 export const computeNodeChecksum = ({
   node,
@@ -302,7 +309,7 @@ export const computeNodeChecksum = ({
   crypto
     .createHash('sha256')
     .update(location_context)
-    .update(node)
+    .update(node ?? '')
     .update(node_before ?? '')
     .digest('base64')
     .toString();