Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔍 Test if all works fine under MS Windows 🪟 #40

Open
3 tasks
tamere-allo-peter opened this issue Mar 17, 2022 · 3 comments
Open
3 tasks

🔍 Test if all works fine under MS Windows 🪟 #40

tamere-allo-peter opened this issue Mar 17, 2022 · 3 comments
Assignees
Labels
help wanted Extra attention is needed RUN

Comments

@tamere-allo-peter
Copy link
Member

  • Check that the software works under MS Windows.
  • Check that --colorsummary works under MS Windows.
  • See what happens if you launch yamlfixer after having removed yamllint : probably all files would be skipped silently, which is bad.
@tamere-allo-peter tamere-allo-peter added the help wanted Extra attention is needed label Mar 17, 2022
@adriens adriens changed the title Test if all works fine under MS Windows 🔍 Test if all works fine under MS Windows 🪟 Mar 17, 2022
@adriens adriens added the RUN label Apr 27, 2022
@giggio
Copy link

giggio commented Oct 6, 2022

I just ran it on Windows and it failed. Log is:

❯ yamlfixer -c .\.yamllint.yml --summary --debug .\build.yml
DEBUG: yamlfixer v0.9.15
DEBUG: arguments=Namespace(backup=False, backupsuffix='.orig', debug=True, diffto='nul', ext='yaml,yml,yamllint', forcecolors=False, followsymlinks=False, listfixers=False, nosyntax=False, nochange=False, recurse=0, jsonsummary=False, plainsummary=False, summary=True, tabsize=2, config_file='.\\.yamllint.yml', config_data=None, filenames=['.\\build.yml'])
DEBUG: Fixing .\build.yml ...
DEBUG: Executing linter with "yamllint --format parsable --strict --config-file '.\\.yamllint.yml' -"
DEBUG: Linter's exit code is 1
DEBUG: was skipped
Files to fix: 1
0 files were already correct before
0 files were modified but problems remain
0 files were entirely fixed
1 files were skipped
0 files were not writable
0 files with unknown status
    SKIPPED .\build.yml

@tamere-allo-peter
Copy link
Member Author

@giggio thanks a lot for your tests. Please could you attach the .yamllint.yml and build.yml files you tested with to this issue ?

@giggio
Copy link

giggio commented Oct 6, 2022

I can't share the build.yml file, but this is the .yamllint.yml:

---
rules:
  line-length: disable
  quoted-strings:
    required: only-when-needed
    quote-type: double

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed RUN
Projects
None yet
Development

No branches or pull requests

3 participants