Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.2 Compatibility #10

Open
ryantfowler opened this issue Dec 17, 2017 · 1 comment
Open

Magento 2.2 Compatibility #10

ryantfowler opened this issue Dec 17, 2017 · 1 comment

Comments

@ryantfowler
Copy link

ryantfowler commented Dec 17, 2017

M2.2 introduced \Magento\Email\Model\Transport whereas the current version of this extension has a di preference for \Magento\Framework\Mail\Transport. A quick-n-dirty fix is to change this for the di.xml preference ... but this breaks backwards compatibility. I suppose either rewriting some of the module to instead implement a Plugin which targets the \Magento\Framework\Mail\TransportInterface or something similar is in order to attempt to keep backwards compatibility ... unless the maintainer(s) would like to create a new release that supports M2.2.x?

In case there are no objections for supporting 2.2 moving forward, there's this PR

@sandip5678
Copy link

Used for M2.2 but not showing headers in the email original message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants