Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse sheet functions #98

Open
jameesjohn opened this issue Jun 29, 2020 · 13 comments
Open

Reuse sheet functions #98

jameesjohn opened this issue Jun 29, 2020 · 13 comments
Labels
bug Something isn't working Impact: Low Work: Low

Comments

@jameesjohn
Copy link
Contributor

jameesjohn commented Jun 29, 2020

The following functions in the checkIssueAssignee module are performing the same functionality as in the apiForSheets module: hasSignedCla, checkAssignees, and need to be refactored to use the functions in the apiForSheets module.

Note that the functions in apiForSheets might need to be refactored support usage in both modules.

@anandwana001
Copy link
Contributor

@jameesjohn
The current codebase doesn't have checkIssueAssigned but it does have checkIssueAssignedSpec file.

@jameesjohn
Copy link
Contributor Author

Oops, my bad.
The name of the file should be checkIssueAssignee.js

@riyasingh1004
Copy link
Contributor

Hi, I would like to work on this issue. Can someone guide me how to get started as I am still trying to understand the codebase.

@jameesjohn
Copy link
Contributor Author

Hi, @riyasingh1004. I'm available to guide you to understand the codebase.

@riyasingh1004
Copy link
Contributor

@jameesjohn thank you. Should I ask all the doubts here or is there a separate channel for the project. Also can you tell me how to get started with this issue.

@jameesjohn
Copy link
Contributor Author

We primarily use hangouts for communication. However, make sure you have signed the CLA which can be found here. Once you are done with that, you can send me a message on hangouts (my email is available on my profile).

Thanks.

@riyasingh1004
Copy link
Contributor

Thank you, I have sent you the message request in hangout and have signed the CLA.

@gp201
Copy link
Member

gp201 commented Feb 2, 2021

@vojtechjelinek Can I take up this issue?

@gp201 gp201 removed their assignment Feb 23, 2021
@nlok5923
Copy link
Contributor

nlok5923 commented Mar 5, 2021

@vojtechjelinek @jameesjohn if this issue is up for grabs i would like give it a try.

@MohdImran001
Copy link

Hey @jameesjohn, can I work on this issue?

@jameesjohn jameesjohn removed the good first issue Good for newcomers label Mar 20, 2021
@jameesjohn
Copy link
Contributor Author

This issue is currently blocked on #195 which is why we can't assign it to anyone.

@seanlip
Copy link
Member

seanlip commented Jan 6, 2023

Note: #195 is already done, so this issue should now be available again.

@seanlip seanlip added bug Something isn't working Impact: Low Work: Low and removed Priority: Low labels Jan 6, 2023
@himanshusharma27
Copy link

I want to work on this issue . Please assign me this issue .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Impact: Low Work: Low
Projects
Status: Todo
Development

No branches or pull requests

9 participants