Remove changlog labels (#314)

* Remove changlog labels

* Fix tests

* Fix tests

* Fix some tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix tests

* Fix stuff

* Fix tests

* Fix tests

* Remove .idea

* Improve coverage

* Use Ubuntu 22.04

Author: vojtechjelinek

.github/workflows/eslint_tests.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on:  ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ubuntu-18.04]
+        os: [ubuntu-22.04]
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1

.github/workflows/frontend_tests.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on:  ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ubuntu-18.04]
+        os: [ubuntu-22.04]
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1

.gitignore

@@ -2,6 +2,7 @@ node_modules
 npm-debug.log
 *.pem
 .env
+.idea
 newrelic_agent.log
 .nyc_output
 coverage

.nycrc

@@ -1,5 +1,5 @@
 {
-  "branches": 87,
+  "branches": 90,
   "lines": 100,
   "functions": 100,
   "statements": 100,

README.md

@@ -6,20 +6,12 @@
 
 Oppiabot is a GitHub app built with [probot](https://github.com/probot/probot). It acts as a helper for the Oppia code repository to maintain the development workflow. It is hosted on [Heroku](https://www.heroku.com/).
 
-The bot currently performs the following functions:
-
-1. Checks whether a contributor creating a pull request has signed the CLA. It adds a label `Needs CLA` accordingly.
-
-2. Checks merge conflict in a pull request and notifies the author of the pull request if there is a merge conflict.
-
-3. Closes stale pull requests.
-
 
 ## Getting started
 
 Please refer to the following instructions to setup Oppiabot for the first time on your machine:
 
-1. Create a new, empty folder called `opensource/` within your home folder. Navigate to it (`cd opensource`), then [fork and clone](https://help.github.com/articles/fork-a-repo/) the Oppiabot repo. This will create a new folder named `opensource/oppiabot`. Navigate to `opensource/oppiabot/`.
+1. Create a new folder called `opensource/` within your home folder (or use one that you already have). Navigate to it (`cd opensource`), then [fork and clone](https://help.github.com/articles/fork-a-repo/) the Oppiabot repo. This will create a new folder named `opensource/oppiabot`. Navigate to `opensource/oppiabot/`.
 
 2. Install [Node.Js](https://nodejs.org/) and [NPM](https://www.npmjs.com/) on your machine using the following commands:
 
@@ -32,13 +24,7 @@ Please refer to the following instructions to setup Oppiabot for the first time
     #### Using Ubuntu
     ```bash
     curl -sL https://deb.nodesource.com/setup_lts.x | sudo -E bash -
-    sudo apt-get install -y nodejs
-    ```
-    
-    #### Using Debian, as root
-    ```bash
-    curl -sL https://deb.nodesource.com/setup_lts.x | bash -
-    apt-get install -y nodejs
+    sudo apt install -y nodejs
     ```
 
     #### Using MacOS
@@ -47,7 +33,7 @@ Please refer to the following instructions to setup Oppiabot for the first time
     ```
 
     #### Using Windows
-    Install using following [link](https://nodejs.org/en/download/). (Its always preferred to use LTS Version).
+    Use [WSL with Ubuntu](https://learn.microsoft.com/en-us/windows/wsl/install) and then follow the Ubuntu instructions.
 
 3. Setup probot and other dependencies by running the following command:
   ```bash
@@ -56,10 +42,6 @@ Please refer to the following instructions to setup Oppiabot for the first time
 
 4. The Oppiabot uses environment variables. These are configured in the server settings. To deploy the bot locally, create a `.env` file and copy the contents of `.env.example` to it. You will need to adjust these variables accordingly following the instructions in the subsequent steps. Run following command to copy `.env.example` to `.env`
 
-If you're using Windows cmd, go to Oppiabot folder and type:
-``` bash
-copy .env.example .env 
-``` 
 If you have Linux terminal type:
   ```bash
     cp .env.example .env
@@ -68,33 +50,36 @@ If you have Linux terminal type:
 5. Go to [smee.io](https://smee.io/) and click **Start a new channel**. Set `WEBHOOK_PROXY_URL` in `.env` to the URL that you are redirected to.
 
 6. [Create a new GitHub App](https://github.com/settings/apps/new) with:
+    * **GitHub App name**: Use something like "My Oppiabot testing App"
+    * **Homepage URL**: Use any random URL
     * **Webhook URL**: Use your `WEBHOOK_PROXY_URL` from the previous step.
     * **Webhook Secret**: `development`
-    * **Permissions & events** The following permissions and events must be subscribed.If, for example, you only enable issue events, you will not be able to listen on pull request webhooks with the bot.
+    * **Permissions & events** The following permissions and events must be subscribed. If, for example, you only enable issue events, you will not be able to listen on pull request webhooks with the bot.
 
 <p align="center">
-  <img src="images/docs/repository-permissions.png">
-  <img src="images/docs/other-permissions.png">
+  <img src="images/docs/repository_permissions.png">
+  <img src="images/docs/organization_permissions.png">
+  <img src="images/docs/account_permissions.png">
   <img src="images/docs/events.png">
 </p>
 
 7. Download the private key. It will be a `.pem` file. Move it to the root directory of the project. As long as it's in the root directory, it will be automatically detected regardless of the filename.
 
 Make sure you remove
  > PRIVATE_KEY=example_private_key
+
 from .env file, Otherwise app will not work locally.
 
-8. Edit `.env` and set `APP_ID` to the ID of the app you just created. The App ID can be found in your app settings page here.
+8. Edit `.env` and set `APP_ID` to the ID of the app you just created and also `WEBHOOK_SECRET` to `development`. The App ID can be found in your app settings page here.
 
 <p align="center">
-    <img src="images/sample-app-id.png">
+    <img src="images/docs/sample_app_id.png">
 </p>
 
 
 ## Installing the bot on a repository
 
-You'll need to identify a target repository and install the bot by clicking the **Install** button on the settings page of your app, e.g `https://github.com/apps/your-app-name`. In the `.env` file put your github account name in 
-`WHITELISTED_ACCOUNTS` and also add your repository (name in small caps) in the `constants.js` file locally.
+You'll need to identify a target repository and install the bot by clicking the **Install** button on the settings page of your app, e.g `https://github.com/settings/apps/my-oppiabot-testing-app/installations`. In the `.env` file put your github account name in `WHITELISTED_ACCOUNTS` and also add your repository (name in small caps) in the `constants.js` file locally.
 
 
 ## Running the bot locally
@@ -104,12 +89,12 @@ The `dev` script will start the bot using [nodemon](https://github.com/remy/node
 
 ### Other available scripts
 
-`$ npm start` to start the bot without watching files.
+`npm start` to start the bot without watching files.
 
 
 ## Debugging
-Always run `$ npm install` and restart the server if `package.json` has changed.
-To turn on verbose logging, start server by running: `$ LOG_LEVEL=trace npm start`.
+Always run `npm install` and restart the server if `package.json` has changed.
+To turn on verbose logging, start server by running: `LOG_LEVEL=trace npm start`.
 Run `npm test` to run all the tests locally.
 
 

actions/src/issues/checkIssueLabels.js

@@ -94,20 +94,11 @@ const handlePRLabel = async (octokit, label, user) => {
   const link = linkText.link(
     'https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#' +
     'labeling-issues-and-pull-requests');
-  let commentBody = '';
-  if (label.startsWith('PR CHANGELOG')) {
-    // Handle case for a changelog label.
-    commentBody = (
-      'Hi @' + user + ', changelog labels should not be used on issues.' +
-      ' I’m removing the label. You can learn more about labels ' + link +
-      '. Thanks!');
-  } else {
-    commentBody = (
-      'Hi @' + user + ', the ' + label + ' label should only be used in ' +
-      'pull requests. I’m removing the label. You can learn more about ' +
-      'labels ' + link + '. Thanks!');
-  }
-
+  const commentBody = (
+    'Hi @' + user + ', the ' + label + ' label should only be used in ' +
+    'pull requests. I’m removing the label. You can learn more about ' +
+    'labels ' + link + '. Thanks!'
+  );
   await octokit.issues.createComment(
     {
       body: commentBody,

constants.js

@@ -34,7 +34,6 @@ const issueCommentCreatedEvent = 'comment_created';
 const periodicCheck = 'periodic-check';
 const claCheck = 'cla-check';
 const claCheckGithubAction = 'cla-check-github-action';
-const changelogCheck = 'changelog-check';
 const datastoreLabelCheck = 'datastore-label-check';
 const prLabelCheck = 'pr-label-check';
 const hotfixLabelCheck = 'hotfix-label-check';
@@ -79,8 +78,8 @@ const checksWhitelist = {
   // eslint-disable-next-line quote-props
   'oppia': {
     [openEvent]: [
+      assigneeCheck,
       claCheck,
-      changelogCheck,
       codeOwnerCheck,
       branchCheck,
       jobCheck,
@@ -92,14 +91,13 @@ const checksWhitelist = {
     [reopenEventGithubActions]: [claCheckGithubAction, wipCheck],
     [editEventGithubActions]: [wipCheck],
     [reopenEvent]: [
-      changelogCheck,
       branchCheck,
       jobCheck,
       cronJobCheck,
       modelCheck,
       prTemplateCheck
     ],
-    [PRLabelEvent]: [assigneeCheck, prLabelCheck, hotfixLabelCheck],
+    [PRLabelEvent]: [prLabelCheck, hotfixLabelCheck],
     [synchronizeEvent]: [
       mergeConflictCheck,
       jobCheck,
@@ -157,7 +155,6 @@ module.exports.issueCommentCreatedEvent = issueCommentCreatedEvent;
 module.exports.periodicCheck = periodicCheck;
 module.exports.claCheck = claCheck;
 module.exports.claCheckGithubAction = claCheckGithubAction;
-module.exports.changelogCheck = changelogCheck;
 module.exports.branchCheck = branchCheck;
 module.exports.wipCheck = wipCheck;
 module.exports.assigneeCheck = assigneeCheck;