From 6649c07a6d5a638640052d383e98c49f83cf5525 Mon Sep 17 00:00:00 2001 From: Aayushi Mathur Date: Sun, 1 Oct 2023 18:05:01 +0530 Subject: [PATCH 1/2] Reformatted dimens xml file for better structure --- app/src/main/res/values/dimens.xml | 535 +++++++++++++++++++---------- 1 file changed, 350 insertions(+), 185 deletions(-) diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index f14ef3f518e..9200bc32701 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -18,217 +18,317 @@ 160dp 4dp 1dp + 18sp - 48dp + 0dp + 12dp + 12dp + 28dp 28dp 28dp + 16dp + + 28dp - 28dp - 28dp - 28dp + 16dp + 24dp + 20dp + + + 64dp + 36dp + 24dp + + + 60dp 28dp + 16dp + 16dp + 16dp + 16dp + 16dp + 16dp + 24dp + 24dp + 24dp + 24dp + 40dp + 8dp + 48dp - 298dp - 298dp 298dp 298dp + 4dp + + + 8dp + 4dp + + + 4dp + 12dp + 8dp + + + 72dp + 72dp + 0dp + 84dp + + + 28dp + + + 96dp + + + 96dp + 224dp + + + 28dp + 16dp + 16dp + 16dp + 60dp + 24dp + 24dp + 298dp + 298dp + 48dp + + + 24dp + 24dp + + + 16dp + 16dp + 16dp + 16dp + + 4dp + 4dp + 4dp + + 40dp + 32dp + 32dp + + 40dp + 24dp + 24dp + + + 32dp + 32dp 40dp + + + 32dp + 32dp + 24dp + + + 16dp + 16dp + + + 12dp + 8dp + + + 8dp + 8dp + + + 8dp + + + 80dp + + + 32dp + 32dp + + + 28dp + 28dp + + + 72dp + 48dp + + 40dp + 24dp + + 40dp - 40dp - 40dp + 24dp + + 40dp + 24dp + 80dp + + + 40dp + 24dp + 24dp + 40dp + 24dp + 24dp + 40dp + 64dp + 64dp + + + 40dp + 24dp + 24dp + + 40dp 40dp - 40dp + 24dp + 24dp + 64dp + 64dp + 24dp + + + 24dp + 64dp + 64dp + + + 16dp + 16dp + + + 8dp + 8dp 28dp - 4dp - 4dp - 4dp - 0dp - 12dp - 12dp + + 20dp + 8dp + + + 20dp + + 60dp 60dp - 20dp - 20dp - 28dp - 28dp - 4dp - 8dp - 28dp - 8dp - 16dp - 12dp - 18sp - 20dp - 20dp - 20dp + 20dp + 24dp + 8dp + 8dp - 16dp - 16dp + 16dp + 24dp + 24dp + 16dp 16dp 16dp 16dp + + 16dp + 24dp + 24dp + 16dp 16dp 16dp 16dp + + 16dp + 24dp + 24dp + 16dp 16dp 16dp 16dp + + 16dp + 24dp + 24dp + 16dp 16dp 16dp 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 16dp - 12dp - 12dp - 12dp - - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 60dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp - 24dp + + 0dp + 0dp 8dp - 8dp - 8dp - 8dp - 8dp - 8dp - 8dp - 8dp - 8dp - 8dp - 8dp - 8dp - 8dp - - 0dp 28dp 28dp + 32dp 96dp + + 0dp 0dp - 0dp @dimen/match_parent + 0dp + 28dp 28dp + 32dp 96dp + + 0dp 0dp - 0dp 0dp + + -1px + 28dp 28dp + 40dp + + 0dp 0dp - - -1px - - 64dp - 64dp - 64dp - 64dp - 64dp - 64dp + 4dp - 4dp - 2dp - 224dp - - 72dp - 72dp - 72dp - - 80dp - 80dp - 32dp - 32dp - 32dp - 32dp - 32dp - 32dp - 32dp - 32dp + + 2dp - 48dp - 48dp - 48dp + + 4dp 24dp @@ -296,6 +396,7 @@ 40dp 24dp 24dp + 40dp 24dp @@ -303,26 +404,15 @@ 32dp 24dp 32dp + 32dp 32dp - - + 32dp 24dp 32dp - - 16dp - 16dp - 16dp - 16dp - - 4dp - - 4dp - 4dp - 16dp 16dp @@ -372,6 +462,7 @@ 20dp 68dp + 20dp @@ -381,6 +472,7 @@ 24dp 24dp + 24dp 24dp @@ -391,6 +483,7 @@ 24dp 24dp + 24dp 24dp @@ -406,7 +499,6 @@ 32dp 32dp - 12dp 32dp 8dp @@ -419,6 +511,15 @@ 124dp + + 48dp + + + 12dp + + + 88dp + 28dp 28dp @@ -438,18 +539,22 @@ 60dp 80dp - + 24dp 22dp 28dp 60dp 80dp - + 80dp 60dp + + 28dp 28dp + + 24dp 24dp 24dp @@ -461,13 +566,15 @@ 128dp - + 12dp - + 28dp 40dp 28dp + + 40dp 28dp 40dp @@ -478,23 +585,23 @@ 32dp 12dp - - 64dp - 36dp - 60dp - 96dp - 0dp - 84dp - 28dp - 96dp - 0dp 0dp + 24dp + + + 16dp + 12dp + + 24dp 24dp + + 4dp + 28dp 28dp @@ -505,9 +612,10 @@ 20dp 20dp + 108dp - + 8dp 8dp 12dp @@ -519,10 +627,12 @@ 20dp 144dp - + 16dp 16dp + 24dp + 28dp @@ -532,18 +642,36 @@ 32dp 24dp + 36dp 148dp + 20dp + 20dp + 8dp + 28dp + + 28dp + 4dp + + + + 0dp + 0dp + 0dp + 0dp - + 8dp 168dp + 28dp + 8dp + + 8dp 8dp 280sp - 280sp 16sp 8dp @@ -563,24 +691,19 @@ 32dp 32dp - - - 0dp - 0dp - 0dp - 0dp - 20dp 20dp 20dp 144dp - + 8dp 12dp 8dp 12dp + + 8dp 8dp @@ -589,56 +712,79 @@ 20dp 20dp 144dp + + 8dp 12dp 8dp 12dp + + 8dp 8dp - 32dp - 12dp 28dp 28dp 20dp + + 8dp + 32dp + 40dp + 40dp + 32dp + 12dp + 12dp + 12dp + 28dp 32dp + 8dp + 0dp 8dp + 8dp + 48dp 48dp - 0dp - 40dp - 40dp - 8dp - 32dp - 8dp - 12dp - 0dp 32dp + + 28dp 28dp + + 28dp 28dp 28dp + + 28dp 28dp 28dp + + 28dp + + 0dp + 32dp + 28dp 28dp 28dp + + 28dp 32dp + 28dp 28dp 32dp @@ -677,14 +823,15 @@ 32dp 32dp - + 32dp - 32dp 24dp - 24dp - 88dp 0dp + + 32dp + 24dp + 8dp 8dp @@ -694,6 +841,7 @@ 20dp 168dp + 0dp 16dp 16dp @@ -701,9 +849,13 @@ 16dp 16dp + + 16dp 16dp 4dp + + 16dp 16dp 4dp @@ -711,6 +863,7 @@ 16dp 16dp + 16dp 16dp @@ -727,12 +880,14 @@ 16dp 20dp 16dp + 16dp 16dp 16dp 16dp + 16dp 16dp @@ -743,8 +898,10 @@ 20dp 20dp + 12dp 12dp + 12dp @@ -757,6 +914,7 @@ 0dp 0dp + 2dp @@ -770,20 +928,27 @@ 4dp + 28dp 12dp 20dp + 12dp - 28dp + 28dp 28dp + 28dp 14dp + 4dp + 28sp 14sp 32dp 32dp + 8dp 16dp + 4dp From 9ad7670dac2959c37b4507a351801e43301741bb Mon Sep 17 00:00:00 2001 From: Aayushi Mathur Date: Wed, 4 Oct 2023 16:37:03 +0530 Subject: [PATCH 2/2] Removed extra Categories and spaces between dimen names --- app/src/main/res/values/dimens.xml | 275 +++++------------------------ 1 file changed, 40 insertions(+), 235 deletions(-) diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index 9200bc32701..11592246d65 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -57,16 +57,11 @@ 40dp 8dp 48dp - 298dp 298dp 4dp - - 8dp 4dp - - 4dp 12dp 8dp @@ -76,18 +71,10 @@ 72dp 0dp 84dp - - - 28dp - - 96dp - - 96dp 224dp - - + 28dp 28dp 16dp 16dp @@ -98,104 +85,68 @@ 298dp 298dp 48dp - - 24dp 24dp - - 16dp - 16dp - 16dp - 16dp - - 4dp - - 4dp - 4dp - - + 40dp 32dp 32dp - - 40dp 24dp 24dp - - 32dp 32dp 40dp - - 32dp 32dp 24dp - - + 16dp + 16dp + 16dp + 16dp + 4dp + 4dp + 4dp + 80dp 16dp 16dp - - 12dp 8dp - - 8dp 8dp - - 8dp - - 80dp - - + + 72dp + 48dp 32dp 32dp - - 28dp 28dp - - 72dp - 48dp - - + 40dp 24dp - - 40dp 24dp - - 40dp 24dp 80dp - + 40dp 24dp 24dp - 40dp 24dp 24dp - 40dp 64dp 64dp - - 40dp 24dp 24dp - - 40dp 40dp 24dp @@ -203,28 +154,20 @@ 64dp 64dp 24dp - - 24dp 64dp 64dp - - 16dp 16dp - - 8dp 8dp 28dp - + 20dp 8dp - - 20dp @@ -237,41 +180,33 @@ 8dp 8dp - + 16dp 24dp 24dp - 16dp 16dp 16dp 16dp - - 16dp 24dp 24dp - 16dp 16dp 16dp 16dp - + 16dp 24dp 24dp - 16dp 16dp 16dp 16dp - - 16dp 24dp 24dp - 16dp 16dp 16dp @@ -280,30 +215,21 @@ 0dp 0dp - 8dp - 28dp 28dp - 32dp 96dp - - 0dp 0dp @dimen/match_parent 0dp - 28dp 28dp - 32dp 96dp - - 0dp 0dp @@ -311,104 +237,76 @@ 0dp -1px - 28dp 28dp - 40dp - - 0dp 0dp - + 4dp - - 2dp 4dp - + 24dp 24dp 40dp - 12dp 16dp 12dp 16dp - - 24dp 24dp 40dp - 12dp 16dp 12dp 16dp - - 32dp 24dp 32dp 8dp - - 32dp 32dp 32dp 8dp - + 24dp 24dp 40dp - 12dp 16dp 12dp 16dp - - 24dp 24dp 40dp - 12dp 16dp 12dp 16dp - - 32dp 24dp 32dp - - 32dp 24dp 32dp - + 40dp 24dp 24dp - 40dp 24dp - - 32dp 24dp 32dp - 32dp 32dp - - 32dp 24dp 32dp @@ -417,39 +315,27 @@ 16dp 16dp - + 40dp 24dp 24dp - - 40dp 24dp 24dp - - 32dp 24dp 32dp - - 32dp 24dp 32dp - + 36dp 52dp - - 36dp 52dp - - 44dp 44dp - - 44dp 44dp @@ -459,41 +345,28 @@ the shadows are clearly visible around the buttons. --> - + 20dp 68dp - 20dp - - 44dp 44dp - - 24dp 24dp - 24dp 24dp - - 44dp 44dp - - 24dp 24dp - 24dp 24dp - + 44dp - - 8dp - + 44dp @@ -520,11 +393,9 @@ 88dp - + 28dp 28dp - - 32dp 32dp @@ -585,37 +456,28 @@ 32dp 12dp - - 0dp - 0dp - - 24dp - 16dp 12dp - - + 0dp + 0dp + 24dp 24dp 24dp - - 4dp - 28dp 28dp - + 36dp 108dp 20dp 20dp - 108dp - + 8dp 8dp 12dp @@ -630,9 +492,7 @@ 16dp 16dp - 24dp - 28dp @@ -649,7 +509,6 @@ 20dp 8dp 28dp - 28dp 4dp @@ -697,13 +556,11 @@ 20dp 144dp - + 8dp 12dp 8dp 12dp - - 8dp 8dp @@ -713,13 +570,10 @@ 20dp 144dp - 8dp 12dp 8dp 12dp - - 8dp 8dp @@ -727,64 +581,45 @@ 28dp 28dp 20dp - 8dp 32dp 40dp 40dp 32dp 12dp - 12dp 12dp - 28dp 32dp - 8dp 0dp 8dp 8dp - 48dp 48dp 32dp - - 28dp 28dp - - 28dp 28dp 28dp - - 28dp 28dp 28dp - - 28dp - - 0dp 32dp - 28dp 28dp 28dp - - 28dp 32dp - 28dp 28dp 32dp @@ -823,12 +658,10 @@ 32dp 32dp - + 32dp 24dp 0dp - - 32dp 24dp @@ -841,55 +674,37 @@ 20dp 168dp - 0dp 16dp 16dp - + 16dp 16dp - - 16dp 16dp 4dp - - 16dp 16dp 4dp - - - 16dp - 16dp - - 16dp - 16dp - - 16dp 16dp 16dp 16dp - - 80dp - - 16dp 20dp 16dp - 16dp 16dp - - 16dp 16dp - 16dp 16dp + 16dp + 16dp + 16dp + 16dp 16dp @@ -898,10 +713,8 @@ 20dp 20dp - 12dp 12dp - 12dp @@ -914,7 +727,6 @@ 0dp 0dp - 2dp @@ -931,24 +743,17 @@ 28dp 12dp 20dp - 12dp - 28dp 28dp - 28dp 14dp - 4dp - 28sp 14sp 32dp 32dp - 8dp 16dp - 4dp