From 962bf5b5fce13f7488fbd6f6fe933d8f80519be0 Mon Sep 17 00:00:00 2001 From: Vishwajith-Shettigar Date: Wed, 6 Sep 2023 15:07:00 +0530 Subject: [PATCH 1/4] contrast issue fixed --- app/src/main/res/values/color_palette.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/app/src/main/res/values/color_palette.xml b/app/src/main/res/values/color_palette.xml index 50e8f6caa30..77f4f6c5da7 100644 --- a/app/src/main/res/values/color_palette.xml +++ b/app/src/main/res/values/color_palette.xml @@ -265,4 +265,5 @@ @color/color_def_chooser_grey @color/color_def_persian_green @color/color_def_grey + @color/color_def_black_54 From df9c695d0ab84762c01995c5d1df51a44c85e599 Mon Sep 17 00:00:00 2001 From: Vishwajith-Shettigar Date: Wed, 6 Sep 2023 17:14:01 +0530 Subject: [PATCH 2/4] contrast issue fixed --- app/src/main/res/color/component_color_textlayout.xml | 5 +++++ app/src/main/res/values-night/color_palette.xml | 2 ++ app/src/main/res/values/color_palette.xml | 5 +++-- app/src/main/res/values/styles.xml | 2 +- 4 files changed, 11 insertions(+), 3 deletions(-) create mode 100644 app/src/main/res/color/component_color_textlayout.xml diff --git a/app/src/main/res/color/component_color_textlayout.xml b/app/src/main/res/color/component_color_textlayout.xml new file mode 100644 index 00000000000..8f82edaf500 --- /dev/null +++ b/app/src/main/res/color/component_color_textlayout.xml @@ -0,0 +1,5 @@ + + + + + \ No newline at end of file diff --git a/app/src/main/res/values-night/color_palette.xml b/app/src/main/res/values-night/color_palette.xml index 7bb64f94cb7..299d498bfc6 100644 --- a/app/src/main/res/values-night/color_palette.xml +++ b/app/src/main/res/values-night/color_palette.xml @@ -225,4 +225,6 @@ @color/color_def_white @color/color_def_oppia_green @color/color_def_pale_green + @color/color_def_black_87 + @color/color_def_white diff --git a/app/src/main/res/values/color_palette.xml b/app/src/main/res/values/color_palette.xml index 77f4f6c5da7..893a42e46f5 100644 --- a/app/src/main/res/values/color_palette.xml +++ b/app/src/main/res/values/color_palette.xml @@ -3,7 +3,7 @@ @color/color_def_oppia_green @color/color_def_dark_green @color/color_def_oppia_dark_blue - @color/color_def_accessible_grey + @color/color_def_black_87 @color/color_def_white @color/color_def_black @color/color_def_accessible_grey @@ -265,5 +265,6 @@ @color/color_def_chooser_grey @color/color_def_persian_green @color/color_def_grey - @color/color_def_black_54 + @color/color_def_black_87 + @color/color_def_black_87 diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index 2be703def67..ae87b597d9a 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -170,7 +170,7 @@ @dimen/text_input_layout_corner_radius @dimen/text_input_layout_corner_radius @dimen/text_input_layout_corner_radius - @color/component_color_shared_text_input_layout_stroke_color + @color/component_color_textlayout @dimen/text_input_layout_stroke_width true @color/component_color_shared_text_input_layout_error_color From 1f61e893ba2c0b376e146d9317fecfe25569f1c4 Mon Sep 17 00:00:00 2001 From: Vishwajith-Shettigar Date: Wed, 6 Sep 2023 17:20:01 +0530 Subject: [PATCH 3/4] contrast issue fixed --- app/src/main/res/values/color_palette.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/res/values/color_palette.xml b/app/src/main/res/values/color_palette.xml index 893a42e46f5..13113daf937 100644 --- a/app/src/main/res/values/color_palette.xml +++ b/app/src/main/res/values/color_palette.xml @@ -3,7 +3,7 @@ @color/color_def_oppia_green @color/color_def_dark_green @color/color_def_oppia_dark_blue - @color/color_def_black_87 + @color/color_def_accessible_grey @color/color_def_white @color/color_def_black @color/color_def_accessible_grey From de60978510734d3faae429991e5b89a165f595ee Mon Sep 17 00:00:00 2001 From: Vishwajith-Shettigar Date: Thu, 7 Sep 2023 07:41:40 +0530 Subject: [PATCH 4/4] fixed snakecase --- ...ent_color_textlayout.xml => component_color_text_layout.xml} | 2 +- app/src/main/res/values/styles.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) rename app/src/main/res/color/{component_color_textlayout.xml => component_color_text_layout.xml} (96%) diff --git a/app/src/main/res/color/component_color_textlayout.xml b/app/src/main/res/color/component_color_text_layout.xml similarity index 96% rename from app/src/main/res/color/component_color_textlayout.xml rename to app/src/main/res/color/component_color_text_layout.xml index 8f82edaf500..9795672d6eb 100644 --- a/app/src/main/res/color/component_color_textlayout.xml +++ b/app/src/main/res/color/component_color_text_layout.xml @@ -2,4 +2,4 @@ - \ No newline at end of file + diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index ae87b597d9a..149d87fd1d1 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -170,7 +170,7 @@ @dimen/text_input_layout_corner_radius @dimen/text_input_layout_corner_radius @dimen/text_input_layout_corner_radius - @color/component_color_textlayout + @color/component_color_text_layout @dimen/text_input_layout_stroke_width true @color/component_color_shared_text_input_layout_error_color