-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Implement messages to celebrate successful first- and second-PR contributions #5547
Comments
Reference: Web repo issue was fixed by this PR Hello everyone, feel free to ask for help with this issue. I'm also available for developer onboarding discussions to plan management once the workflow is active. Thanks! |
Hello @HardikGoyal2003 , please assign this issue to me i am eager to complete it. |
@MohitGupta121 PTAL!! Thanks! |
Hi @Mayank77maruti, thanks for your interest in this issue! Could you please give a brief breakdown of how you propose to solve this issue? Then we can assign it to you. |
Hello @adhiamboperes Sir, We can add a GitHub Action that will trigger when a PR gets merged into the develop branch. The action can be configured as follows: In the .github/workflow directory, we will add this YAML file: yaml
This GitHub Action will be triggered by a pull request event, fetch the source and base branches, and perform a merge into the base branch. It will also handle authentication and sets a custom user name and email for the merge commit. |
Hey @Mayank77maruti, please ensure the workflow includes the username of the Android developer onboarding lead, not the web lead. Thanks! cc: @adhiamboperes |
Ok sir , I would make sure. |
Hey @HardikGoyal2003 sir should i make a pr regarding this issue or wait to be assigned for the issue. |
@Mayank77maruti, please create a Par and assign it to me. |
Hey @adhiamboperes , I have made a pr regarding this issue, |
<!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> Fixes #5547 This PR introduces a new GitHub Action that automatically posts a comment on a pull request once it has been merged into the develop branch. The comment provides different feedback based on whether it is the user's first or second merged PR to the repository. ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
<!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> Fixes oppia#5547 This PR introduces a new GitHub Action that automatically posts a comment on a pull request once it has been merged into the develop branch. The comment provides different feedback based on whether it is the user's first or second merged PR to the repository. ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Is your feature request related to a problem? Please describe.
On Web, we now have functionality (thanks to @HardikGoyal2003!) to send a congratulatory note when contributors submit their first and second PRs. See the following examples:
Per discussion with @BenHenning, we'd like to do this for Oppia Android too, so I'm filing this issue to track it.
Describe the solution you'd like
Provide congratulatory messages when a new contributor submits their first and second PRs.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: