Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Remove the old home activity/fragment and other related files [Blocked] #5505

Open
1 task
theMr17 opened this issue Aug 22, 2024 · 2 comments
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@theMr17
Copy link
Collaborator

theMr17 commented Aug 22, 2024

Is your feature request related to a problem? Please describe.

Issue #5344 tracks the implementation of the new Classroom List Screen, which will replace the existing Home Screen. Once the new screen is stable, all unused code related to the old screen, including the ENABLE_MULTIPLE_CLASSROOMS feature flag, should be removed.

Describe the solution you'd like

Here is a brief overview of the steps:

  • Remove HomeActivity, HomeFragment & its associated presenters along with HomeViewModel.
  • Migrate the following files from the app/home to the app/classroom package.
    • app/home/HomeItemViewModel
    • app/home/RouteToExplorationListener
    • app/home/RouteToRecentlyPlayedListener
    • app/home/RouteToTopicListener
    • app/home/RouteToTopicPlayStoryListener
  • Migrate the following subpackages from app/home to app/classroom package. (Note: corresponding subpackages already exist in app/classroom. Move all files from app/home to those subpackages):
    • app/home/classroomlist/..
    • app/home/promotedlist/..
    • app/home/recentlyplayed/..
    • app/home/topiclist/..
  • Delete the app/home package after the migration.
  • Remove the getTopicList function from TopicListController and all related functions (such as createTopicList, loadTopicListFromJson, createEphemeralTopicSummary, and so on). Note: the Classroom List Screen now uses the new ClassroomController for the getTopicList function.
  • Remove the gating logic for HomeActivity and ClassroomListActivity from the following activities to directly open ClassroomListActivity:
    • PinPasswordActivity
    • ProfileChooserFragment
    • NavigationDrawerFragment
    • MyDownloadsActivity
  • Remove the ENABLE_MULTIPLE_CLASSROOMS feature flag.

Additional context

Ensure that all corresponding test files are removed or updated accordingly for each of the above changes.

  • NavigationDrawerActivityDebugTest and NavigationDrawerActivityProdTest should be updated.
  • [ ]

Note: This issue is blocked until the Multiple Classrooms feature is stable and will be ready to work on once approval is received from the TLs.

@theMr17 theMr17 added enhancement End user-perceivable enhancements. triage needed labels Aug 22, 2024
@seanlip
Copy link
Member

seanlip commented Aug 27, 2024

@theMr17 Could you please update the list of steps for this issue? Thanks.

@theMr17
Copy link
Collaborator Author

theMr17 commented Aug 28, 2024

@seanlip I realized that I forgot to add the steps after including the TODO earlier. The steps have now been added.

@adhiamboperes adhiamboperes added Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Aug 29, 2024
@adhiamboperes adhiamboperes changed the title Remove the old home activity/fragment and other related files [Blocked] Feature Request: Remove the old home activity/fragment and other related files [Blocked] Aug 29, 2024
@BenHenning BenHenning added this to the 1.0 Global availability milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Development

No branches or pull requests

4 participants