[Feature Request]: Create means for verifying Fragment Arguments

[adhiamboperes]

Is your feature request related to a problem? Please describe.

We use Espresso Intents.Intended to verify activity intent params, but we also need to test the fragment arguments and saved state bundles for correcteness, and to prevent bugs during development.

Describe the solution you'd like

// TODO

Describe alternatives you've considered

// TODO

Additional context

No response

[subhajitxyz]

Ho @adhiamboperes , can i work on this ?

[adhiamboperes]

Hi, sure, please look into it and let us know your proposed solution.

…

On Sat, Aug 17, 2024, 08:41 Subhajit Mallick ***@***.***> wrote: Ho @adhiamboperes <https://github.com/adhiamboperes> , can i work on this ? — Reply to this email directly, view it on GitHub <#5485 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOGXANFS4L3FQWNLEB4RYL3ZR3O77AVCNFSM6AAAAABMQAN5M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJUGYZTONRZGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[subhajitxyz]

Sure.

[subhajitxyz]

Hi @adhiamboperes , please check my approach and share your views on it.

   @Test
    fun testMarkTopicsCompletedFragment_SaveInstanceState_workProperly() {
      launch<MarkTopicsCompletedTestActivity>(
        createMarkTopicsCompletedTestActivityIntent(internalProfileId)
      ).use { scenario ->
        testCoroutineDispatchers.runCurrent()
        scenario.onActivity { activity ->
  
          var fragment = activity.supportFragmentManager
            .findFragmentById(R.id.mark_topics_completed_container) as MarkTopicsCompletedFragment
  
          fragment.markTopicsCompletedFragmentPresenter.selectedTopicIdList =
            arrayListOf("topic_1", "topic_2")
  
          activity.recreate()
  
          fragment = activity.supportFragmentManager
            .findFragmentById(R.id.mark_topics_completed_container) as MarkTopicsCompletedFragment
  
          val restoredTopicIdList = fragment.markTopicsCompletedFragmentPresenter.selectedTopicIdList
          assertThat(restoredTopicIdList).isEqualTo(listOf("topic_1", "topic_2"))
        }
      }
    }
  
  
  @Test
    fun testAudioFragment_arguments_workingProperly() {
      addMediaInfo()
      launch<AudioFragmentTestActivity>(
        createAudioFragmentTestIntent(internalProfileId)
      ).use { scenario ->
        testCoroutineDispatchers.runCurrent()
        scenario.onActivity { activity ->
  
          val audioFragment = activity.supportFragmentManager
            .findFragmentById(R.id.audio_fragment_placeholder) as AudioFragment
          val receivedProfileId = audioFragment.arguments?.extractCurrentUserProfileId()
  
          assertThat(receivedProfileId).isEqualTo(profileId)
        }
      }
    }

[adhiamboperes]

Hi @subhajitxyz, the approach does look good. For the implementation, please opt to create a PR with only a small subset of packages at once, rather than all the fragment tests in one PR. For example, we have about 30 packages, so we could do this in 3 different PRs for ease of review.

[subhajitxyz]

Ok, fine.

[subhajitxyz]

Hi @adhiamboperes ,
My previous approach for testing saveInstanceState works fine on Expresso test but it failed on robolectric test.

So ,I have changed my approach little bit . try to recreate the scenario instead of activity.

please check it and share your views.

Here is my new approach.

@Test
  fun testFragment_saveInstanceState_restoresSelectedTopicsCorrectly() {
    launch<MarkTopicsCompletedTestActivity>(
      createMarkTopicsCompletedTestActivityIntent(internalProfileId)
    ).use { scenario ->
      testCoroutineDispatchers.runCurrent()
      onView(withId(R.id.mark_topics_completed_all_check_box_container)).perform(click())
      var actualSelectedTopicsList = ArrayList<String>()

      scenario.onActivity { activity ->

        var fragment = activity.supportFragmentManager
          .findFragmentById(R.id.mark_topics_completed_container) as MarkTopicsCompletedFragment
        actualSelectedTopicsList =
          fragment.markTopicsCompletedFragmentPresenter.selectedTopicIdList
        }

        scenario.recreate()

        scenario.onActivity { activity->
          val fragment1 = activity.supportFragmentManager
            .findFragmentById(R.id.mark_topics_completed_container) as MarkTopicsCompletedFragment
          val restoredTopicIdList = fragment1.markTopicsCompletedFragmentPresenter.selectedTopicIdList

          assertThat(restoredTopicIdList).isEqualTo(actualSelectedTopicsList)
        }
      }
  }