[BUG]: Multiple substitutions specified in non-positional format of string resource #5484
Comments
MohitGupta121
added
bug
github-project-automation
bot
moved this to Todo
in [Team] Developer Workflow & Infrastructure - Android
|
Hi, I’m interested in working on this issue. Could you please assign it to me? |
|
@Raghav1783, Could you please make sure that you are able to reproduce this issue, and then give a brief description of what's causing it an the suggested fix? |
|
@adhiamboperes yes i am able to reproduce this error . String resource has multiple %s . To avoid this, we must identify each like this: %1$s |
|
@adhiamboperes should i create a pr? |
|
@Raghav1783, to reproduce means to perform the steps that caused the error to occur. For this specific issue, it would be great to see proof of this issue occuring on either your computer, or our GitHub CI. This way we can evaluate the before and after build isues and verify that your fix worked. If this is possible on your end, please feel free to create a PR. |
|
Hi @adhiamboperes, I would like to work on this issue. This error appears every time I clean and rebuild the project. This issue seems to be related to the custom function getStringInLocale used for retrieving strings
|
|
I am currently researching this further, but I am having trouble locating the implementation of the sealed class OppiaLocale. Any guidance on where I might find it would be greatly appreciated. |
|
@jainv4156 please double check the OppiaLocale class.
|
|
I’ve identified the main issue and found the solution. It is what @Raghav1783 suggested. Should I go ahead and create a PR now? |
|
@jainv4156, please go ahead and create the PR |
github-project-automation
bot
moved this from Todo
to Done
in [Team] Developer Workflow & Infrastructure - Android
github-project-automation
bot
moved this from Done
to In Progress
in [Team] Developer Workflow & Infrastructure - Android
github-project-automation
bot
moved this from In Progress
to Done
in [Team] Developer Workflow & Infrastructure - Android
github-project-automation
bot
moved this from In Progress
to Done
in [Team] Developer Workflow & Infrastructure - Android
…itional forma…" This reverts commit 55ab73e.
…format of st… (oppia#5560) ## Explanation Fixes : oppia#5484 Some string resources have multiple %s . To fix the error, we must identify each string position with a number : %1$s ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). --------- Co-authored-by: Adhiambo Peres <[email protected]>
Describe the bug
Steps To Reproduce
Build app and see build logs
Expected Behavior
There should be no multiple strings
Screenshots/Videos
No response
What device/emulator are you using?
No response
Which Android version is your device/emulator running?
No response
Which version of the Oppia Android app are you using?
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: