Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Setup instructions for JDK 8 on Mac no longer work #5384

Closed
kkmurerwa opened this issue Apr 14, 2024 · 5 comments
Closed

[BUG]: Setup instructions for JDK 8 on Mac no longer work #5384

kkmurerwa opened this issue Apr 14, 2024 · 5 comments
Assignees
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: High High perceived user impact (breaks a critical feature or blocks a release). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@kkmurerwa
Copy link
Collaborator

kkmurerwa commented Apr 14, 2024

Describe the bug

When working with the Bazel setup instructions for Mac, the step involving installing JDK 8 using AdoptOpenJDK and Homebrew no longer works and gives the error below.
image

This issue happens because the adoptopenjdk cask is being deprecated in favour of temurin.

Steps To Reproduce

Uninstall your AdoptOpenJDK8 and try to reinstall it using the instructions on step 3 of the Bazel Mac setup page.

Expected Behavior

I expect the installation to go on as expected.

To fix this issue, follow the steps below as described in the solution for this issue.

  1. Untap the AdoptOpenJDK Cask
brew untap AdoptOpenJDK/openjdk
  1. Update cask versions
brew tap homebrew/cask-versions
  1. Install Temurin in the place of the AdoptOpenJDK cask
brew install --cask temurin8

Screenshots/Videos

No response

What device/emulator are you using?

Pixel 3a

Which Android version is your device/emulator running?

Android 10

Which version of the Oppia Android app are you using?

No response

Additional Context

To work on this Issue, you need a Macbook. Test out the wiki instructions and apply the suggestion in this issue. If it works, create a PR to update the wiki.

While working on this issue, be sure to note down any issues you encounter during bazel set up.

@kkmurerwa kkmurerwa added bug End user-perceivable behaviors which are not desirable. triage needed labels Apr 14, 2024
@seanlip seanlip added Impact: High High perceived user impact (breaks a critical feature or blocks a release). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. and removed triage needed labels Apr 14, 2024
@adhiamboperes
Copy link
Collaborator

@kkmurerwa, per the information you have provided in the issue, What changes need to be made? Is it only updating the documentation to point to temurin instead of openjdk?

@kkmurerwa
Copy link
Collaborator Author

@adhiamboperes that is correct. The only change needed is switching from AdoptOpenJDK to Temurin.

@kkmurerwa kkmurerwa assigned adhiamboperes and unassigned kkmurerwa May 1, 2024
@adhiamboperes adhiamboperes removed their assignment May 1, 2024
@adhiamboperes adhiamboperes added the good first issue This item is good for new contributors to make their pull request. label May 1, 2024
@adhiamboperes
Copy link
Collaborator

@kkmurerwa, #4886 updates Bazel to 6.5, and openjdk11. Has support for adoptopenjdk11 also been deprecated?

@BenHenning
Copy link
Member

Is this still needed @kkmurerwa / @adhiamboperes now that we're no longer using the local JDK for anything in Bazel?

@adhiamboperes
Copy link
Collaborator

@BenHenning, closing this since the jdk setup step has already been removed from the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: High High perceived user impact (breaks a critical feature or blocks a release). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Development

No branches or pull requests

4 participants