Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Static Analysis Checks not running locally #5301

Closed
adhiamboperes opened this issue Jan 16, 2024 · 5 comments
Closed

[BUG]: Static Analysis Checks not running locally #5301

adhiamboperes opened this issue Jan 16, 2024 · 5 comments
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@adhiamboperes
Copy link
Collaborator

Describe the bug

Some Static Analysis Checks are not running locally with error scripts/static_checks.sh: line 100: bazel: command not found

Steps To Reproduce

In a checked out oppia-android folder path on terminal, run bash scripts/static_checks.sh.

This requires a working bazel set up.

Expected Behavior

All checks to run successfully.

Screenshots/Videos

Screenshot 2024-01-16 at 09 34 43

What device/emulator are you using?

N/A

Which Android version is your device/emulator running?

MacOs Sononoma 14.2.1

Which version of the Oppia Android app are you using?

No response

Additional Context

Need to repro this on Linux to confirm it is not a Mac only issue.

@adhiamboperes adhiamboperes added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). bug End user-perceivable behaviors which are not desirable. Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Jan 16, 2024
@adhiamboperes
Copy link
Collaborator Author

Hi @kkmurerwa, could you please try to repro this on your end? Feel free to unassign yourself afterwards if you are unable to put up a PR.

@kkmurerwa
Copy link
Collaborator

@adhiamboperes I believe the only reason this could happen is if Bazel is not installed. Are other Bazel commands running?

@adhiamboperes
Copy link
Collaborator Author

@adhiamboperes I believe the only reason this could happen is if Bazel is not installed. Are other Bazel commands running?

Yes, but I will need to check maybe the bazel path is not set correctly.

@manas-yu
Copy link
Collaborator

manas-yu commented Dec 5, 2024

@adhiamboperes I believe the only reason this could happen is if Bazel is not installed. Are other Bazel commands running?

Yes, but I will need to check maybe the bazel path is not set correctly.

I attempted to reproduce the issue, and everything works fine on my end. I have Bazel set up correctly, and the check is running without any issues locally.

@adhiamboperes
Copy link
Collaborator Author

Thanks @manas-yu! This works correctly for me now as well. I believe I had earlier not completed my Bazel configuration, and a lot has changed since then to simplify Bazel setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Development

No branches or pull requests

3 participants