Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Fix UnusedAttribute Lint Warning #5273

Open
Tracked by #5169
adhiamboperes opened this issue Dec 14, 2023 · 9 comments
Open
Tracked by #5169

[Bug]: Fix UnusedAttribute Lint Warning #5273

adhiamboperes opened this issue Dec 14, 2023 · 9 comments
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@adhiamboperes
Copy link
Collaborator

adhiamboperes commented Dec 14, 2023 •
edited
Loading

An easy way to repro the issue is to navigate to Code -> Inspect Code.

image

Then check on Whole Project and click on Analyze.

image
@adhiamboperes adhiamboperes mentioned this issue Dec 14, 2023
Open
25 tasks
@adhiamboperes adhiamboperes changed the title UnusedAttribute [Bug]: Fix UnusedAttribute Lint Warning Dec 14, 2023
@adhiamboperes
Copy link
Collaborator Author

Suggested fix: #5169 (comment)

One more thing, new binding adapters should be added to the bazel app/BUILD.bazel file so they can work with bazel as well. See example:
Screenshot 2023-12-14 at 13 58 48

@adhiamboperes
Copy link
Collaborator Author

@pingu-73, PTAL

@pingu-73
Copy link
Contributor

Suggested fix: #5169 (comment)

One more thing, new binding adapters should be added to the bazel app/BUILD.bazel file so they can work with bazel as well. See example: Screenshot 2023-12-14 at 13 58 48

Thanks @adhiamboperes

@adhiamboperes adhiamboperes added good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). bug End user-perceivable behaviors which are not desirable. Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Dec 14, 2023
@Tejas-67
Copy link
Contributor

Is this issue open? @adhiamboperes

@rishav2404
Copy link

Is this still open ? I want to work on this.

@pingu-73
Copy link
Contributor

pingu-73 commented Jan 4, 2024

Is this still open ? I want to work on this.

I'm already working on it.

@shalenMathew
Copy link

is this issue still open ?

@predator313
Copy link

predator313 commented Jan 14, 2024 •
edited
Loading

hey is this issue still open?? I want to work on this

@pingu-73 pingu-73 removed their assignment Mar 5, 2024
@tobioyelekan
Copy link
Contributor

HI @adhiamboperes can I pick this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Projects
[Team] Developer Workflow & Infrastructure - Android
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
7 participants
@tobioyelekan @adhiamboperes @predator313 @Tejas-67 @rishav2404 @shalenMathew @pingu-73