Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test cases for HtmlParser and UrlImageParser #455

Closed
rt4914 opened this issue Nov 20, 2019 · 1 comment · Fixed by #5589
Closed

Improve test cases for HtmlParser and UrlImageParser #455

rt4914 opened this issue Nov 20, 2019 · 1 comment · Fixed by #5589
Assignees
@manas-yu
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
1.x GA Follow-up ...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Nov 20, 2019 •
edited by seanlip
Loading

HtmlParser and UrlImageParser code was updated to improve the UI, which needs new test cases to check these improvements.

Also, check this comment: #454 (review)
@BenHenning BenHenning added this to the Beta milestone Jun 23, 2020
@BenHenning BenHenning modified the milestones: Beta, Beta MR1, Beta MR2 Jun 11, 2022
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta MR2 milestone Sep 16, 2022
@seanlip seanlip moved this from Needs Triage to In Progress: Needs mocks in [Team] Core Learner and Mastery flows & UI Frontend - Android Dec 19, 2022
@seanlip seanlip moved this from In Progress: Needs mocks to Todo in [Team] Core Learner and Mastery flows & UI Frontend - Android Dec 19, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_type_infrastructure labels Mar 28, 2023
@seanlip seanlip changed the title Improvise test cases for HtmlParser and UrlImageParser Improve test cases for HtmlParser and UrlImageParser Mar 28, 2023
@adhiamboperes adhiamboperes added Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). and removed Impact: Low Low perceived user impact (e.g. edge cases). labels Sep 22, 2023
@adhiamboperes adhiamboperes added this to the 1.0 Global availability milestone Apr 18, 2024
@BenHenning BenHenning removed this from the 1.0 Global availability milestone Oct 10, 2024
@BenHenning BenHenning added this to the 1.x GA Follow-up Items milestone Oct 10, 2024
@manas-yu
Copy link
Collaborator

manas-yu commented Dec 3, 2024

Hi @adhiamboperes,
I would like to work on this issue. I'll start by adding tests for the updates made in PRs #404 and #454. If there are any additional tests you'd like me to include, please let me know.

@manas-yu manas-yu mentioned this issue Dec 5, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manas-yu manas-yu

Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Status: Done
Milestone
1.x GA Follow-up Items
Development

Successfully merging a pull request may close this issue.

Fix #455: Improve Html parser tests manas-yu/oppia-android
7 participants
@rt4914 @seanlip @BenHenning @veena14cs @adhiamboperes @Broppia @manas-yu