Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add networking support for KitKat devices #3954

Closed
BenHenning opened this issue Oct 20, 2021 · 3 comments
Closed

Add networking support for KitKat devices #3954

BenHenning opened this issue Oct 20, 2021 · 3 comments
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

Is your feature request related to a problem? Please describe.
Per https://medium.com/square-corner-blog/okhttp-3-13-requires-android-5-818bb78d07ce, OkHttp dropped support for KitKat devices due to the need to upgrade to TLS 1.2 and compatibility problems with KitKat & TLS 1.2. #3910 disabled OkHttp in KitKat builds to work around this issue.

Describe the solution you'd like
We should look into the difficulty of supporting networking in KitKat devices. This is part of a broader strategy discussion of whether & how we want to support KitKat devices.

Describe alternatives you've considered
We're also considering dropping networking support altogether & relying on embedded lessons, or dropping KitKat support altogether.

Additional context
None

@BenHenning
Copy link
Member Author

From a technical perspective, we have a few choices:

We could potentially go with a hybrid option where we make a best-effort basis to support download functionality, but fallback to embedded lessons specifically for KitKat devices. Since we now have dedicated KitKat builds, it's certainly possible for us to only embed lessons for KitKat devices.

@BenHenning
Copy link
Member Author

Also: we will need to use OkHttp 3.12.12+ (square/okhttp#4481 (comment) -- see https://github.com/square/okhttp/tree/okhttp_3.12.x). The blog indicates this branch will only be maintained until EOY 2020, but it seems like there are still changes. This presents some risk since it's not clear how long the branch will stick around.

@Broppia Broppia added issue_type_feature Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Jun 13, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. TODO: need task force Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed TODO: need task force labels Sep 16, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_user_learner labels Mar 29, 2023
@seanlip
Copy link
Member

seanlip commented Jun 4, 2023

Per #5012, we are deprecating support for Android KitKat, so this issue is no longer valid.

@seanlip seanlip closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Development

No branches or pull requests

3 participants