Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use caption-with-value from <oppia-interactive-image> in RichText #3188

Closed
rt4914 opened this issue May 12, 2021 · 3 comments · Fixed by #5593
Closed

Use caption-with-value from <oppia-interactive-image> in RichText #3188

rt4914 opened this issue May 12, 2021 · 3 comments · Fixed by #5593
Assignees
@manas-yu
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
1.x GA Follow-up ...

Comments

@rt4914
Copy link
Contributor

rt4914 commented May 12, 2021

Currently oppia-interactive-image is used to render images in RichText.
We should use caption-with-value from oppia-interactive-image to show a caption below the image in application.
@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. Status: Not started Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels May 12, 2021
@Victor-Titan
Copy link
Contributor

@rt4914 I'd like to work on this. How should I go about it?

@rt4914
Copy link
Contributor Author

rt4914 commented May 22, 2021

@rt4914 I'd like to work on this. How should I go about it?

@Victor-Titan You can start with ImageTagHandler in utility module. It might be too hard at first but if you get stuck feel free to unassign.

@rt4914 rt4914 changed the title Use caption-with-value from <oppia-interactive-image> in RichText [A11y] Use caption-with-value from <oppia-interactive-image> in RichText May 25, 2021
@Victor-Titan Victor-Titan removed their assignment Jul 5, 2021
@rt4914 rt4914 removed their assignment Jul 7, 2021
@rt4914 rt4914 changed the title [A11y] Use caption-with-value from <oppia-interactive-image> in RichText Use caption-with-value from <oppia-interactive-image> in RichText Jul 7, 2021
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@Broppia Broppia added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). and removed Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added issue_type_enhancement and removed Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). issue_type_infrastructure labels Sep 15, 2022
@BenHenning BenHenning added Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_learner labels Sep 15, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_user_learner labels Mar 29, 2023
@adhiamboperes adhiamboperes added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks. and removed Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Jul 16, 2023
@BenHenning BenHenning added this to the 1.0 Global availability milestone Aug 29, 2024
@manas-yu
Copy link
Collaborator

manas-yu commented Dec 6, 2024 •
edited
Loading

Hi @adhiamboperes can i work on this, i can add the caption-with-value tag in the ImageTagHandler and its related tests.
The handler will retrieve the caption from the caption-with-value tag and append the caption as a new line below the image using SpannableStringBuilder

@manas-yu manas-yu self-assigned this Dec 10, 2024
@manas-yu manas-yu mentioned this issue Dec 10, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manas-yu manas-yu

Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Status: Done
Milestone
1.x GA Follow-up Items
Development

Successfully merging a pull request may close this issue.

Fix #3188: Added caption-with-value in ImageTagHandler manas-yu/oppia-android
7 participants
@rt4914 @seanlip @BenHenning @Victor-Titan @adhiamboperes @Broppia @manas-yu