Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute affected tests doesn't handle moved files correctly #3022

Closed
BenHenning opened this issue Mar 29, 2021 · 3 comments
Closed

Compute affected tests doesn't handle moved files correctly #3022

BenHenning opened this issue Mar 29, 2021 · 3 comments
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

See #2970 & #3018 for context. If files are moved to a new location, compute affected tests won't properly compute affected targets since it seems to primarily use the old targets. Ideally, we should be compute the targets affecting both the old & new files, if possible.
@BenHenning BenHenning added Priority: Essential This work item must be completed for its milestone. Status: Not started labels Mar 29, 2021
@BenHenning
Copy link
Member Author

BenHenning commented Mar 29, 2021 •
edited
Loading

NB: this is a nice issue to dig into for contributors interested in developing their Bazel expertise.

@BenHenning BenHenning added this to the Beta MR2 milestone Jun 11, 2022
@Broppia Broppia added issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). and removed Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta MR2 milestone Sep 16, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_user_developer labels Mar 29, 2023
@BenHenning
Copy link
Member Author

@Rd4dev this reminds me of the similar issue you ran into when writing the script to compute which targets on which to run code coverage. You made some changes to BazelClient--do you think that change would fix ComputeAffectedTests for moved files, as well?

@BenHenning
Copy link
Member Author

Closing this in favor of #4035 since it's a duplicate. While that one is newer, it contains more information. :)

@BenHenning BenHenning closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2024
@Rd4dev Rd4dev mentioned this issue Aug 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Task Force] Migrate to Bazel - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seanlip @BenHenning @Broppia