Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HomeFragment PromotedStory Download Status [Blocked: #169] #283

Open
rt4914 opened this issue Oct 31, 2019 · 3 comments
Open

HomeFragment PromotedStory Download Status [Blocked: #169] #283

rt4914 opened this issue Oct 31, 2019 · 3 comments
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Oct 31, 2019 •
edited
Loading

Promoted Story in HomeFragment contains Download Status at the top-right corner of the card, implement this with other download functionalities.

https://xd.adobe.com/spec/e2239cf4-9cde-4c08-5296-25316c1f0a14-9412/screen/d47aa8de-a7a8-4d25-b011-5baefc7b7098/HP-Home-Page-
@BenHenning BenHenning added this to the Beta milestone Jun 23, 2020
@anandwana001 anandwana001 self-assigned this Mar 31, 2021
@anandwana001 anandwana001 modified the milestones: Beta, Topic Download App Layer Mar 31, 2021
@anandwana001 anandwana001 removed their assignment Oct 13, 2021
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added issue_type_enhancement Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed issue_type_infrastructure labels Sep 15, 2022
@BenHenning BenHenning removed this from the Topic Download App Layer milestone Sep 16, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_user_learner labels Mar 29, 2023
@adhiamboperes adhiamboperes added Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. and removed Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. labels Aug 14, 2023
@BenHenning
Copy link
Member

Downloads functionality is on hold and will be undergoing a reassessment of design. We'll have to figure out all of the UI changes necessary in order to finish this work (which may not include the change described here), so I don't think that we need to keep this open anymore.

@BenHenning BenHenning closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2024
@github-actions github-actions bot reopened this Aug 30, 2024
@github-actions GitHub Actions
Copy link

The issue is reopened because of the following unresolved TODOs:

oppia-android/app/src/main/java/org/oppia/android/app/home/promotedlist/PromotedStoryViewModel.kt

Line 15 in 0ef7a46

// TODO(#283): Add download status information to promoted-story-card.

@BenHenning
Copy link
Member

BenHenning commented Aug 30, 2024 •
edited
Loading

Ah, I think we can just remove that TODO in order to be able to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rt4914 @seanlip @BenHenning @anandwana001 @adhiamboperes @Broppia