You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Currently, we have Ktlint run over GitHub Actions and at each commit, the developer has to resolve if any error occurs.
Describe the solution you'd like
If we introduce the pre-commit hook, the Ktlint will run on developer's local machine and the issue will be resolved before coming to PR.
Additional context
Currently, we have Ktlint and we have to add more in the below list once other linters added.
Ktlint
Buildifier
Start working on these after the gets added
Checkstyle
XML
The text was updated successfully, but these errors were encountered:
Note that one challenge here is that pre-commit hooks must be setup locally by the team member, and we don't yet have any part of our starting workflow that involves scripts. This might change with Bazel, but we ideally should figure out a way to integrate populating the pre-commit hooks as part of the build process via Android Studio since most contributors will probably only be using Android Studio.
Is your feature request related to a problem? Please describe.
Currently, we have Ktlint run over GitHub Actions and at each commit, the developer has to resolve if any error occurs.
Describe the solution you'd like
If we introduce the pre-commit hook, the Ktlint will run on developer's local machine and the issue will be resolved before coming to PR.
Additional context
Currently, we have Ktlint and we have to add more in the below list once other linters added.
Start working on these after the gets added
The text was updated successfully, but these errors were encountered: