Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Pre-Commit hooks #1837

Closed
4 tasks
anandwana001 opened this issue Sep 13, 2020 · 2 comments
Closed
4 tasks

Introduce Pre-Commit hooks #1837

anandwana001 opened this issue Sep 13, 2020 · 2 comments
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@anandwana001
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, we have Ktlint run over GitHub Actions and at each commit, the developer has to resolve if any error occurs.

Describe the solution you'd like
If we introduce the pre-commit hook, the Ktlint will run on developer's local machine and the issue will be resolved before coming to PR.

Additional context
Currently, we have Ktlint and we have to add more in the below list once other linters added.

  • Ktlint
  • Buildifier

Start working on these after the gets added

  • Checkstyle
  • XML
@BenHenning
Copy link
Member

Note that one challenge here is that pre-commit hooks must be setup locally by the team member, and we don't yet have any part of our starting workflow that involves scripts. This might change with Bazel, but we ideally should figure out a way to integrate populating the pre-commit hooks as part of the build process via Android Studio since most contributors will probably only be using Android Studio.

@anandwana001
Copy link
Contributor Author

Duplicate of #637
Closing this one

@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Development

No branches or pull requests

3 participants